fix: blob fees #11029
Open
fix: blob fees #11029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
I think we still need to make a few more changes to how the price bump is computed, but this should fix the error we're seeing now in Sepolia.
Also, I'm not a fan of passing the blobs as a separate third argument in the API. I'd expect them to be part of the request object. I know you didn't introduce it though, but I'd consider changing it eventually.
| const blobBaseFeeHex = await this.publicClient.request({ method: 'eth_blobBaseFee' }); | ||
| blobBaseFee = BigInt(blobBaseFeeHex); | ||
| } catch { | ||
| // Ignore if not supported |
There was a problem hiding this comment.
Let's at least log this as a warn. I'm worried about a scenario where the blobBaseFee request fails due to a connectivity error and we end up sending the tx with zero fee.
Comment on lines
+376
to
+377
| const blobBaseFeeHex = await this.publicClient.request({ method: 'eth_blobBaseFee' }); | ||
| blobBaseFee = BigInt(blobBaseFeeHex); |
There was a problem hiding this comment.
I understand we should be increasing the blob base fee to 12.5% per stall time in blocks, as we do with the base fee (see here).
Comment on lines
423
to
428
| const bumpPercentage = | ||
| gasConfig.priorityFeeRetryBumpPercentage! > MIN_REPLACEMENT_BUMP_PERCENTAGE | ||
| ? gasConfig.priorityFeeRetryBumpPercentage! | ||
| : MIN_REPLACEMENT_BUMP_PERCENTAGE; | ||
|
|
||
| blobBaseFee = (previousGasPrice.maxFeePerBlobGas * (100n + bumpPercentage)) / 100n; |
There was a problem hiding this comment.
Why do we use the priorityFeeRetryBumpPercentage here? I'd expect that we just need to use the MIN_REPLACEMENT_BUMP_PERCENTAGE expected by geth (which comes from here apparently).
Also, we need to account for the current blob base fee, and do something similar to what we do for the calldata fee: use the minimum between the current chain blob base fee (bumped by 12.5% per stall time) and geth's minimum bump (10%) wrt the previous price.
There was a problem hiding this comment.
thanks for that 🙏
I was googling to find if there was such a percentage but couldn't find it so I used this patchy solution.
I should go directly to geth code from now on
There was a problem hiding this comment.
I should go directly to geth code from now on
Yup. I learned that the hard way. Anything related to mempool management is out of protocol, so it depends on the clients, and is awfully undocumented.
Comment on lines
+356
to
+357
| // Blob transactions should require more gas | ||
| expect(blobEstimate).toBeGreaterThan(baseEstimate); |
There was a problem hiding this comment.
Curious: why is this? Does eth_estimateGas return both the execution gas and the blob gas mixed up together?
There was a problem hiding this comment.
it seems in our estimateGas, we have to use prepareTransactionRequest to get a full estimation, which does increase a lot compared to estimateGas so I assumed that includes the blob gas
spypsy
force-pushed
the
spy/tx-utils-blobs
branch
from
d07b6ed to
e7b3f71
Compare
spalladino
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Good find on the blob bump being 100% instead of 10%. But note that the 100% bump is applied to all gas fields, not just maxFeePerBlobGas according to this code. In other words, if the tx has blobs, the minimum bump is 100% for the maxFeePerBlobGas, the maxFeePerGas, and the maxPriorityFeePerGas.
spalladino
reviewed
Jan 7, 2025
| // calculate min blob fee based on previous attempt | ||
| const minBlobFee = (previousGasPrice.maxFeePerBlobGas * (100n + bumpPercentage)) / 100n; | ||
|
|
||
| // use max between current network values and min required values |
There was a problem hiding this comment.
Sorry I didn't catch this one earlier, but I believe we're missing the check to not go over gasConfig.maxGwei with the blob fee. Given we're duplicating it on every attempt, let's make sure it's in there.
… into spy/tx-utils-blobs
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #11005