Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a boolean property to 4 components to know if it is a multi tenancy instance. #81

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gklijs
Copy link

@gklijs gklijs commented Aug 8, 2024

Since this changes the client API, maybe we should change the milestone to 1.8.0?

@gklijs gklijs added this to the 1.7.3 milestone Aug 8, 2024
@gklijs gklijs requested a review from a team August 8, 2024 15:30
@gklijs gklijs self-assigned this Aug 8, 2024
@gklijs gklijs requested review from corradom, CodeDrivenMitch, smcvb, sandjelkovic and stefanmirkovic and removed request for a team August 8, 2024 15:30
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading to 1.8.0 doesn't seem weird to me!
And, approved 👍

Copy link
Collaborator

@CodeDrivenMitch CodeDrivenMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some changes for backwards compat first, other than that it looks good.
Indeed looks like 1.8.0 to me!

…ramework/api/clientIdentification.kt

Co-authored-by: Mitchell Herrijgers <[email protected]>
Copy link

@gklijs gklijs requested a review from CodeDrivenMitch August 15, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants