Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting the aggregate size. This will help getting the size when … #48

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Fix getting the aggregate size. This will help getting the size when … #48

merged 1 commit into from
Feb 13, 2024

Conversation

gklijs
Copy link

@gklijs gklijs commented Feb 12, 2024

…either snapshotting or caching is used.
fixes (#26

@gklijs gklijs added Priority 1: Must Type: Bug Backend This issue contains backend changes labels Feb 12, 2024
@gklijs gklijs requested a review from a team February 12, 2024 08:59
@gklijs gklijs self-assigned this Feb 12, 2024
@gklijs gklijs requested review from corradom, CodeDrivenMitch, smcvb, sandjelkovic and stefanmirkovic and removed request for a team February 12, 2024 08:59
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

CodeDrivenMitch
CodeDrivenMitch approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@CodeDrivenMitch CodeDrivenMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

smcvb
smcvb approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@gklijs gklijs merged commit dc9893f into main Feb 13, 2024
10 checks passed
@smcvb smcvb deleted the bug/missing-aggregate-size branch February 13, 2024 09:02
@gklijs gklijs added this to the V1.4.0 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandjelkovic sandjelkovic sandjelkovic approved these changes

@smcvb smcvb smcvb approved these changes

@CodeDrivenMitch CodeDrivenMitch CodeDrivenMitch approved these changes

@corradom corradom Awaiting requested review from corradom corradom was automatically assigned from AxonIQ/axoniq-console

@stefanmirkovic stefanmirkovic Awaiting requested review from stefanmirkovic stefanmirkovic was automatically assigned from AxonIQ/axoniq-console

Assignees

@gklijs gklijs

Labels
Backend This issue contains backend changes Priority 2: Should Type: Bug
Projects
None yet
Milestone
V1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gklijs @CodeDrivenMitch @smcvb @sandjelkovic