Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the case for the processing group(s) not matching the processor name. #36

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Support the case for the processing group(s) not matching the processor name. #36

merged 1 commit into from
Nov 14, 2023

Conversation

gklijs
Copy link

@gklijs gklijs commented Nov 10, 2023

Needs some additional changes here and there to get it working.

@gklijs gklijs requested review from a team, schananas, corradom, CodeDrivenMitch, smcvb, sandjelkovic and stefanmirkovic and removed request for a team November 10, 2023 15:23
@gklijs gklijs self-assigned this Nov 10, 2023
@gklijs gklijs added this to the V1.0.3 milestone Nov 10, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

smcvb
smcvb approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems fine to me. Although, it took me some time to follow the flow while knowing the intent. Perhaps it's good to share the intent of this change in some documentation so that it's going to be clear for others.

@gklijs gklijs merged commit ca22425 into main Nov 14, 2023
6 checks passed
@gklijs gklijs deleted the add_support_for_processing_group_not_matching_processor_name branch November 14, 2023 12:07
@CodeDrivenMitch CodeDrivenMitch modified the milestones: V1.0.3, V1.2.0 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@schananas schananas Awaiting requested review from schananas schananas was automatically assigned from AxonIQ/axoniq-console

@corradom corradom Awaiting requested review from corradom corradom was automatically assigned from AxonIQ/axoniq-console

@CodeDrivenMitch CodeDrivenMitch Awaiting requested review from CodeDrivenMitch CodeDrivenMitch was automatically assigned from AxonIQ/axoniq-console

@sandjelkovic sandjelkovic Awaiting requested review from sandjelkovic sandjelkovic was automatically assigned from AxonIQ/axoniq-console

@stefanmirkovic stefanmirkovic Awaiting requested review from stefanmirkovic stefanmirkovic was automatically assigned from AxonIQ/axoniq-console

Assignees

@gklijs gklijs

Labels
Priority 3: Could Status: Resolved Type: Enhancement
Projects
None yet
Milestone
V1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gklijs @smcvb @CodeDrivenMitch