Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CAMARA-ICM-examples.md #4

Open
wants to merge 1 commit into
base: icm_examples
Choose a base branch
from

Conversation

Elisabeth-Ericsson
Copy link

Fixed purpose value in examples to comply to w3C vocabulary and added examples on http responses and token request

What type of PR is this?

  • correction
  • enhancement/feature
  • documentation

What this PR does / why we need it:

Some typing error was included in an example. The PR fixes this example.

Which issue(s) this PR fixes:

The problem is named in a comment to pull request 121, no separate issue is raised.

Special notes for reviewers:

Please review the extensions to the examples adding the HTTP responses as well as the POST request for the access token,

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Fixed purpose value in examples to comply to w3C vocabulary and added examples on http responses and token request
@AxelNennker
Copy link
Owner

Sorry @Elisabeth-Ericsson , I was traveling because May 1st is a holiday here and did not see this PR. I changed the file and now there are merge conflicts.

Although, I am not sure about the HTTP "decoration". I left those out because I wanted to focus on the purpose parts.
And I want to remove all two-purpose examples for now, because I think those lead to discussions I currently don't want to focus on.
I am astonished that I missed the missing sub field, because I copied the examples from some spec, thinking that they must be correct.

Not sure, how to proceed with this PR.

  1. close it and create smaller ones, that e.g. add sub?
  2. resolve merge conflicts and merge?

WDYT?

@mhfoo
Copy link

mhfoo commented May 6, 2024

@AxelNennker

I believe the RFC9101 request object examples should have the following claims, as per RFC7519:

exp: Expiration Time Claim
nbf: Not Before Claim
iat: Issued At Claim
jti: JWT ID Claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants