Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Use Verify.Avalonia #138

Merged
merged 17 commits into from
Aug 29, 2023
Merged

Use Verify.Avalonia #138

merged 17 commits into from
Aug 29, 2023

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@wieslawsoltes
Copy link
Contributor

wieslawsoltes commented Aug 28, 2023

@SimonCropp Can UsesVerify have conditional usage depending on Platform, sometime it's tricky to get font rendering right on Linux/macOS - see current PR fails now, added explicit FontFamily, hope it will help, but it's not always possible.

@wieslawsoltes
Copy link
Contributor

@SimonCropp Looks like I can use UniqueForOSPlatform()

@wieslawsoltes
Copy link
Contributor

@SimonCropp I have switched to mono font for all OSs and added separate png's for each OS. But now I get random failures using Verify

@wieslawsoltes
Copy link
Contributor

@SimonCropp it's not the issue with comparers, it runs ok on all local machines (macOS, Linux and Windows), it's issue running unit tests on CI where it randomly fails

@wieslawsoltes wieslawsoltes merged commit 46e516a into AvaloniaUI:master Aug 29, 2023
15 checks passed
@wieslawsoltes
Copy link
Contributor

@SimonCropp thanks for PR, merged!

@SimonCropp SimonCropp deleted the verify branch August 29, 2023 11:12
@SimonCropp
Copy link
Contributor Author

out of curiosity. what method of snapshot management are you using? DiffEngineTray / Rider test runner support etc?

@wieslawsoltes
Copy link
Contributor

out of curiosity. what method of snapshot management are you using? DiffEngineTray / Rider test runner support etc?

Manual one for now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants