Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

lov type for adapter & lov type is str (#1015) #1016

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

FredLL-Avaiga
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga commented Nov 17, 2023

Addresses Avaiga/taipy#567

import taipy as tp

fruit_list = ["apple", "banana", "cherry"]
selected_fruit = fruit_list[0]

flower_list = ["rose", "tulip", "daisy"]
selected_flower = flower_list[0]
md = """
# Select fruit

<|{selected_fruit}|selector|lov={fruit_list}|adapter={lambda s: s.upper()}|>

# Select fruit

<|{selected_fruit}|slider|lov={fruit_list}|labels|adapter={lambda s: s.capitalize()}|>

# Select flower

<|{selected_flower}|selector|lov={flower_list}|>

# Select flower

<|{selected_flower}|slider|lov={flower_list}|labels|>
"""

tp.Gui(md).run(run_browser=False, use_reloader=True)

@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be fixed ASAP 📈 Improvement Improvement of a feature. Gui: Back-End Related to the back-end side of Taipy GUI. 📝Release Notes Impacts the Release Notes labels Nov 17, 2023
@FredLL-Avaiga FredLL-Avaiga self-assigned this Nov 17, 2023
Copy link

github-actions bot commented Nov 17, 2023

Coverage report for gui

Branches coverage not met for global: expected >=80%, but got 62.432675044883304%

St.
Category Percentage Covered / Total
🟢 Statements 80.85% 2293/2836
🟡 Branches 62.43% 1391/2228
🟡 Functions 75.38% 401/532
🟢 Lines 81.21% 2127/2619

Test suite run success

334 tests passing in 36 suites.

Report generated by 🧪jest coverage report action from 267edbc

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5207 4493 86% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/taipy/gui/_renderers/builder.py 83% 🟢
TOTAL 83% 🟢

updated for commit: 267edbc by action🐍

Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some magic... but that looks fine!

@FredLL-Avaiga FredLL-Avaiga merged commit e39cdc5 into develop Nov 18, 2023
48 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the bug/#1015-lov-type branch November 18, 2023 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Gui: Back-End Related to the back-end side of Taipy GUI. 📈 Improvement Improvement of a feature. 🟥 Priority: Critical Must be fixed ASAP 📝Release Notes Impacts the Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants