Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Update several /client components to replace formatNumnber with i18n-calypso numberFormat #99156

Open
wants to merge 3 commits into
base: update/fix-number-format-a8c-for-agencies
Choose a base branch
from

Conversation

chriskmnds
Copy link
Contributor

@chriskmnds chriskmnds commented Jan 31, 2025

Part of addressing https://github.com/Automattic/i18n-issues/issues/934

Proposed Changes

  • Refactors several @automattic/components:formatNumber instances to go through i18n-calypso:numberFormat
  • These are straight forward cases of compact notation. The options are carried through inline for now. We may create an abstraction later.

Why are these changes being made?

See https://github.com/Automattic/i18n-issues/issues/934

Testing Instructions

Various cases need to be tested separately, but one or two should suffice as they are all the same.

  • go to /devdocs Blocks and confirm AuthorCompactProfile renders subscribers count without decimals
Screenshot 2025-01-31 at 6 43 23 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 31, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~400 bytes removed 📉 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-purchases         -969 B  (-0.1%)     -397 B  (-0.2%)
a8c-for-agencies-client            -949 B  (-0.1%)     -381 B  (-0.1%)
a8c-for-agencies-marketplace       -883 B  (-0.1%)     -334 B  (-0.1%)
subscribers                        -111 B  (-0.0%)      -28 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1096 bytes removed 📉 [gzipped])

name                                              parsed_size           gzip_size
async-load-calypso-blocks-reader-full-post             -963 B  (-2.4%)     -372 B  (-3.1%)
async-load-design-blocks                               -944 B  (-0.0%)     -375 B  (-0.1%)
async-load-calypso-reader-site-stream                  -938 B  (-4.9%)     -371 B  (-5.8%)
async-load-calypso-reader-feed-stream                  -938 B  (-4.8%)     -371 B  (-5.6%)
async-load-calypso-my-sites-stats-pages-purchase        +12 B  (+0.0%)      +22 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@chriskmnds chriskmnds marked this pull request as ready for review January 31, 2025 17:33
@chriskmnds chriskmnds requested a review from a team as a code owner January 31, 2025 17:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2025
@chriskmnds chriskmnds requested a review from a team January 31, 2025 17:34
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/i18n-numnber-format-update-client-components on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n: number-format [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants