Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 69331: ETK deactivation message on unlaunched site #79889

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

samiff
Copy link
Contributor

@samiff samiff commented Jul 26, 2023

Proposed Changes

Follow-up to #69331
Closes #79804

This reverts commit e67ae55.

As the coming-soon functionality has now been moved to the jetpack-mu-wpcom package which is utilized in wpcomsh for WoA sites.

Testing Instructions

  • When deactivating the updated ETK plugin, there should no longer be the "Disabling this plugin will make your site public" message displayed.
  • Coming Soon functionality should otherwise remain unchanged.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@samiff samiff added Coming Soon Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin labels Jul 26, 2023
@samiff samiff self-assigned this Jul 26, 2023
@github-actions
Copy link

github-actions bot commented Jul 26, 2023

@samiff samiff force-pushed the revert/69331-etk-deactivation-message branch from 7d76ba8 to cb61b94 Compare July 26, 2023 20:19
@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit revert/69331-etk-deactivation-message on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@samiff samiff requested a review from miksansegundo July 26, 2023 20:46
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 26, 2023
Copy link
Contributor

@miksansegundo miksansegundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@miksansegundo miksansegundo linked an issue Jul 27, 2023 that may be closed by this pull request
4 tasks
@samiff samiff merged commit 4aef37b into trunk Jul 27, 2023
@samiff samiff deleted the revert/69331-etk-deactivation-message branch July 27, 2023 16:46
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coming Soon Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETK: Remove warning about site privacy when deactivating plugin
3 participants