Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-DOS: essential fixes for Dotcom launch #8626

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Jan 23, 2025

On this commit, I fixed the following issues commented on #8506:

  • Removed the navigation and pagination blocks from the column structure and made both wide;
  • Added the required No Results paragraph block;
  • Fixed the Search block, removing the width spec;
  • Adjusted the overlay in all cover elements, making the background one for all templates;
  • Made Comments a template and moved it to a new column;
  • Removed bundled Overused Grotesk and system-font;
  • Fixed the values for the custom font size presets in the theme.json;
  • Fixed Jetbrains font presets;
  • Listed the templates in the theme.json, including the new comments;
  • Hopefully, after the CBT save Header, Footer, and the 404 template are now internationalized;
  • Used Post Meta correctly on the single post template, as required;
  • Fixed the main tags in all the templates;
  • Removed unused patterns: hidden-no-results-content.php. The other, comments.php is now being use;
  • Updated info: Tested up to and Requires PHP as needed;
  • Changed the version number;
  • Removed incorrect tags listed.

@henriqueiamarino henriqueiamarino self-assigned this Jan 23, 2025
Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: WP-DOS.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@iamtakashi
Copy link
Contributor

iamtakashi commented Jan 24, 2025

@henriqueiamarino Thanks for the updates! As we discussed, I pushed a change with a new post meta template part (the "+" sign inside the template part doesn't need to be internationalised), and changed the archives template just to show you how you could do the same to other templates. Could you do the same for the templates could share the post meta template part? (if you don't have time, I don't mind doing that myself at all.)

@henriqueiamarino
Copy link
Collaborator Author

Thanks, @iamtakashi. I did this by copying the whole column structure into the Query Loop. I used Archive as the source of truth and repeated it on the Index and Search Results templates. Now that I see the Blog Home should also have one, I'll commit to a final fix.

@iamtakashi
Copy link
Contributor

Nice one. This is solid. Merging!

@iamtakashi iamtakashi merged commit ee4f21e into trunk Jan 24, 2025
2 checks passed
@iamtakashi iamtakashi deleted the update/wp-dos-dotcom-improvements branch January 24, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants