Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stewart: Remove Query block from the page template #8581

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

michalczaplinski
Copy link
Contributor

Changes proposed in this Pull Request:

  • Remove unnecessary Query block wrapper from page template
  • Fix template structure to properly display single page content instead of a posts list

Related issue(s):

Fixes #8547

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Stewart.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

Theme-Check results

stewart: No changes required ✅.

⚠️ WARNING (5)
  • Found ="' alt='<?php echo esc_html__( 'An abstract image featuring a brushstroke.', 'ste
  • Found ="' alt='<?php echo esc_html__( 'A collage featuring the portrait of a woman.', 's
  • Found ="<?php echo esc_html__ in patterns/page-contact.php. Use esc_attr__() inside HTML attributes, and esc_url() for link attributes. A manual review is needed. Line 13: alt='<?php echo esc_html__( 'An abstract image featuring a brushstroke.', 'ste
  • Found ="<?php echo esc_html__ in patterns/sidebar-background.php. Use esc_attr__() inside HTML attributes, and esc_url() for link attributes. A manual review is needed. Line 14: alt='<?php echo esc_html__( 'An abstract image featuring a brushstroke.', 'ste
  • Found ="' alt='<?php echo esc_html__( 'A collage featuring the portrait of a woman.', 's

Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alaczek alaczek merged commit 2fb3fa6 into trunk Jan 15, 2025
5 checks passed
@alaczek alaczek deleted the fix/stewart-page-template branch January 15, 2025 22:57
@alaczek
Copy link
Contributor

alaczek commented Jan 15, 2025

Merged & deployed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Stewart [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stewart: Default Page template contains Content block in Query Loop causing issues editing individual pages
3 participants