Pendant: layout for index template #5751
Conversation
MaggieCabrera
changed the title
MaggieCabrera
force-pushed
the
pendant-index-template
branch
from
c5d9a47 to
4e0d33d
Compare
pendant/theme.json
Outdated
| "typography": { | ||
| "fontWeight": "500", | ||
| "textTransform": "uppercase", | ||
| "fontSize": "var(--wp--preset--font-size--small)" |
There was a problem hiding this comment.
The comps suggest this is the "extra small" font size (15px), but it doesn't look like that variable is configured yet via custom theme.json settings. Should we add it?
There was a problem hiding this comment.
yeah I think you are right
| <!-- wp:query {"queryId":1,"query":{"perPage":4,"pages":0,"offset":0,"postType":"post","order":"desc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"exclude","inherit":true},"tagName":"main","displayLayout":{"type":"flex","columns":2},"layout":{"inherit":true}} --> | ||
| <main class="wp-block-query"><!-- wp:group {"align":"wide","style":{"spacing":{"padding":{"top":"1em","bottom":"1.5em"}}}} --> | ||
| <div class="wp-block-group alignwide" style="padding-top:1em;padding-bottom: 1.5em"><!-- wp:post-template --> | ||
| <!-- wp:group {"style":{"spacing":{"padding":{"top":"2em","bottom":"2em"}}}} --> |
There was a problem hiding this comment.
I think the comps suggest there is less spacing here but I think yours looks good so maybe we leave it to the design pass of the templates.
|
What do you folks think about the heading up top? |
Could we make it a If we can't, I think static that we replace with a hidden pattern for translation purposes works too. |
This makes me think when index.html will ever appear if we have home.html and archive.html defined... According to https://developer.wordpress.org/themes/basics/template-hierarchy/ that's... never |
|
True — if we define home and archive, index will never be used. Since Pendant will have a home template, should we switch this one to archive? |
Well, we need index.html because without it the theme isn't detected as a block theme and the editor doesn't work. We could add the query title to index and remove the archive template instead but I think I'm going to open a GB issue about this because this doesn't make much sense in this case. |
|
Made a few minor tweaks but going to bring this in. Leaving the attached issue open for final design sign off. |
Changes proposed in this Pull Request:
This PR introduces the changes to the index template to fit the design. I don't know what to do about the heading on top of the page, so for now I made it to be static text. If we go with that we should make it a hidden pattern for i18n.
There are a few GB PRs needed for some of the blocks to work like in the design. They have been recently merged or are about to:
WordPress/gutenberg#39796
WordPress/gutenberg#39835
Related issue(s):
May address #5681