Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the query pagination block #93

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR tweaks the pagination block. The main change is when the justification setting is set to "space between" (which should be the default setting -- the template will need to be updated) so it uses a grid, meaning the pagination numbers are always centered (from screens >= 600px).

Other small changes include:

  • added a mixin for css transition (at the moment only all, we can update this if we want more flexibility)
  • removed the option to use custom spacing so our theme follows strict gap sizes

How to test the changes in this Pull Request:

  1. Add query block with pagination, set justification to space-between
  2. Check results
  3. Switch to this branch and refresh page

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! The only issue I ran into is how the block wraps on smaller screens, but that has nothing to do with these changes (it's more the baked-in behaviour of the block, I get the same thing on master).

Making the default labels shorter (Previous instead of Previous Page) helps a bit, if we wanted to make that change when the actual block settings are updated -- though we might have to do that in the templates themselves vs. the block settings.

@thomasguillot
Copy link
Contributor Author

This looks good! The only issue I ran into is how the block wraps on smaller screens, but that has nothing to do with these changes (it's more the baked-in behaviour of the block, I get the same thing on master).

Making the default labels shorter (Previous instead of Previous Page) helps a bit, if we wanted to make that change when the actual block settings are updated -- though we might have to do that in the templates themselves vs. the block settings.

Yeah I noticed this too. I think it will need to be done in the templates – which is fine I guess.

@thomasguillot thomasguillot merged commit 03e7fb6 into master Nov 25, 2023
2 checks passed
@thomasguillot thomasguillot deleted the update/query-pagination branch November 25, 2023 10:32
@laurelfulford
Copy link
Contributor

... which is fine I guess.

It's not the only thing like this happening there, I don't think we can avoid it! 😄

matticbot pushed a commit that referenced this pull request Jan 26, 2024
# [1.5.0-alpha.1](v1.4.0...v1.5.0-alpha.1) (2024-01-26)

### Bug Fixes

* parenthesis ([a0c485f](a0c485f))
* remove link from post date archive ([#90](#90)) ([d08ba5e](d08ba5e))

### Features

* add 2x-small font size ([#102](#102)) ([cb17fdc](cb17fdc))
* add new "Paul" style ([#88](#88)) ([5605dab](5605dab))
* update archive template ([#89](#89)) ([3c8556d](3c8556d))
* update button block ([#91](#91)) ([b66f75a](b66f75a))
* update button style ([#103](#103)) ([4b686f9](4b686f9))
* update desktop header template part ([#106](#106)) ([b5d45ba](b5d45ba))
* update footer part and lock blocks ([#105](#105)) ([0490354](0490354))
* update grid and typography ([64c70d7](64c70d7))
* update grid and typography ([f5073ef](f5073ef))
* update svg icons and search overlay ([#111](#111)) ([9ee5b6a](9ee5b6a))
* update the query pagination block ([#93](#93)) ([03e7fb6](03e7fb6))
@matticbot
Copy link

🎉 This PR is included in version 1.5.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 6, 2024
# [1.5.0](v1.4.0...v1.5.0) (2024-02-06)

### Bug Fixes

* parenthesis ([a0c485f](a0c485f))
* remove link from post date archive ([#90](#90)) ([d08ba5e](d08ba5e))

### Features

* add 2x-small font size ([#102](#102)) ([cb17fdc](cb17fdc))
* add new "Paul" style ([#88](#88)) ([5605dab](5605dab))
* update archive template ([#89](#89)) ([3c8556d](3c8556d))
* update button block ([#91](#91)) ([b66f75a](b66f75a))
* update button style ([#103](#103)) ([4b686f9](4b686f9))
* update desktop header template part ([#106](#106)) ([b5d45ba](b5d45ba))
* update footer part and lock blocks ([#105](#105)) ([0490354](0490354))
* update grid and typography ([64c70d7](64c70d7))
* update grid and typography ([f5073ef](f5073ef))
* update svg icons and search overlay ([#111](#111)) ([9ee5b6a](9ee5b6a))
* update the query pagination block ([#93](#93)) ([03e7fb6](03e7fb6))
@matticbot
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants