Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update grid and typography #87

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Conversation

thomasguillot
Copy link
Contributor

@thomasguillot thomasguillot commented Nov 3, 2023

All Submissions:

Changes proposed in this Pull Request:

Introduces a new grid, typography, and spacing. We also have a custom class that can be added to the Columns Block newspack-grid, allowing us to perfectly control the layout when using 3 columns.

Note: This is a first pass

newspack-fse-theme-new-grid

How to test the changes in this Pull Request:

  1. Create homepage with bunch of block (especially columns)
  2. Switch to this branch
  3. Refresh homepage

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @thomasguillot! I see the subtle changes, but I don't see any issues with them.

The only thing may be worth keeping an eye on is the use of the tertiary colour in the theme.json settings, since all of those elements can now be changed if that colour is changed in the Style settings. So far that's only an issue in my head so it might be fine -- and there are legitimate reasons to change those colours, too 🙂

Anyway - long way to say :shipit:

@thomasguillot
Copy link
Contributor Author

The only thing may be worth keeping an eye on is the use of the tertiary colour in the theme.json settings, since all of those elements can now be changed if that colour is changed in the Style settings.

I think users should be able to change they different greys so I'm not to worried. Next, I was going to experiment with a new style.

@thomasguillot thomasguillot merged commit 64c70d7 into master Nov 4, 2023
3 checks passed
@thomasguillot thomasguillot deleted the update/grid-typography branch November 4, 2023 11:15
@matticbot
Copy link

🎉 This PR is included in version 1.5.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants