feat: add header mobile patterns #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelfulford
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Thanks @thomasguillot! The different mobile header options are nice!
This one works as described, too. I think seeing both mobile and the desktop designs together as options is confusing, but I'm not sure of the best way to get it to work nicer. The ability to swap the template parts so easily is really nice, it's just hard to select the right spot in the header to get to the swapping, and to make sure you're picking the correct parts.
I don't think this is a blocker to this PR at all, more of a thing to figure out down the road -- through documentation, further tweaks (maybe additional template part areas could help?), or something else. 🙂
All I can think is we have some sort of custom interface which seems overkill. Ideally, the pattern can support custom template-part: * Block Types: core/template-part/header-mobile |
matticbot
pushed a commit
that referenced
this pull request
Jul 19, 2024
# [1.12.0-alpha.1](v1.11.0...v1.12.0-alpha.1) (2024-07-19) ### Bug Fixes * **buttons:** outline variations missing style with wp 6.6 ([#270](#270)) ([dabae5b](dabae5b)) * **navigation:** correct gap between items when using responsive nav ([#243](#243)) ([b707642](b707642)) * **newspack-grid:** adjust large and extra large screens ([#256](#256)) ([47b748c](47b748c)) * **search-results:** no results apply alignwide to homepage articles ([#242](#242)) ([315bc59](315bc59)) * sticky element with admin bar on small screens ([#238](#238)) ([2f2b056](2f2b056)) ### Features * add 50/50 Image/Header single post template ([#268](#268)) ([a010920](a010920)) * add blank screenshot ([#252](#252)) ([8839ea5](8839ea5)) * add columns patterns ([#274](#274)) ([41290a7](41290a7)) * add drawer menu pattern; reorganise overlays ([#244](#244)) ([4cdb255](4cdb255)) * add footer patterns and update template part ([#177](#177)) ([615c2a2](615c2a2)) * add header desktop patterns ([#254](#254)) ([ff6d296](ff6d296)) * add header mobile patterns ([#255](#255)) ([e1f371d](e1f371d)) * add margin to alignleft and alignright elements ([#261](#261)) ([97140de](97140de)) * add optional mobile-only and desktop-only to fixed elements ([#246](#246)) ([2cdfc1b](2cdfc1b)) * add sidebar grid layout ([#258](#258)) ([cb29dc6](cb29dc6)) * add sidebar-contents template part and use it for single sidebar layout ([#276](#276)) ([488e43c](488e43c)) * add support for yoast blocks (faq, how-to) ([#241](#241)) ([d63260a](d63260a)) * add support for yoast breadcrumbs; move cap styles to subdirectory ([#239](#239)) ([463584e](463584e)) * **author-list:** add block styles ([#250](#250)) ([7acd4a3](7acd4a3)) * **breadcrumbs:** ensure text and link colors are supported ([#240](#240)) ([fb3e939](fb3e939)) * **button:** x-small size adjust min-height and border-radius for consistency with newspack-icon ([#271](#271)) ([5fa1f7c](5fa1f7c)) * **footer:** add new pattern and adjust style 4 ([#269](#269)) ([9e826e9](9e826e9)) * **footer:** update credits ([#278](#278)) ([cec87b1](cec87b1)) * **homepage-articles:** add transition to links ([#234](#234)) ([bdf924a](bdf924a)) * **navigation:** update hover style; remove underline and use color-mix instead ([#247](#247)) ([08994a3](08994a3)) * **overlay:** update close button to 64px tall/wide ([#233](#233)) ([39e9dad](39e9dad)) * **patterns:** add 1 new footer pattern ([#257](#257)) ([758e38c](758e38c)) * **patterns:** improve columns preview; add 25/25/25/25 ([#275](#275)) ([0f5427f](0f5427f)) * **post-carousel:** update style ([#249](#249)) ([d87ac30](d87ac30)) * **post-meta:** update hover state ([#251](#251)) ([b1ba1d5](b1ba1d5)) * reorganise header parts ([#253](#253)) ([14ee203](14ee203)) * **search:** update template part to match pagination with archive ([#279](#279)) ([6e3da20](6e3da20)) * simplify home and index templates to match page and archive; remove archive pattern ([#277](#277)) ([5d09c60](5d09c60)) * update comments elements names ([#235](#235)) ([27e963e](27e963e)) * update mobile menu elements names ([#237](#237)) ([a1f5070](a1f5070)) * update post header patterns; add wide option ([#267](#267)) ([1bd4d76](1bd4d76)) * update post header to use pattern; introduce sidebar post template ([#262](#262)) ([ff015a1](ff015a1)) * update post-content; adjust align left/right position ([#280](#280)) ([b1a5378](b1a5378)) * update search elements names ([#236](#236)) ([0f926d2](0f926d2))
|
🎉 This PR is included in version 1.12.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
For the near term at least it'll be more of an internal thing than external, since we can help folks set things up with the right pieces 🙂 |
matticbot
pushed a commit
that referenced
this pull request
Jul 30, 2024
# [1.12.0](v1.11.0...v1.12.0) (2024-07-30) ### Bug Fixes * **buttons:** outline variations missing style with wp 6.6 ([#270](#270)) ([dabae5b](dabae5b)) * **navigation:** correct gap between items when using responsive nav ([#243](#243)) ([b707642](b707642)) * **newspack-grid:** adjust large and extra large screens ([#256](#256)) ([47b748c](47b748c)) * **search-results:** no results apply alignwide to homepage articles ([#242](#242)) ([315bc59](315bc59)) * sticky element with admin bar on small screens ([#238](#238)) ([2f2b056](2f2b056)) ### Features * add 50/50 Image/Header single post template ([#268](#268)) ([a010920](a010920)) * add blank screenshot ([#252](#252)) ([8839ea5](8839ea5)) * add columns patterns ([#274](#274)) ([41290a7](41290a7)) * add drawer menu pattern; reorganise overlays ([#244](#244)) ([4cdb255](4cdb255)) * add footer patterns and update template part ([#177](#177)) ([615c2a2](615c2a2)) * add header desktop patterns ([#254](#254)) ([ff6d296](ff6d296)) * add header mobile patterns ([#255](#255)) ([e1f371d](e1f371d)) * add margin to alignleft and alignright elements ([#261](#261)) ([97140de](97140de)) * add optional mobile-only and desktop-only to fixed elements ([#246](#246)) ([2cdfc1b](2cdfc1b)) * add sidebar grid layout ([#258](#258)) ([cb29dc6](cb29dc6)) * add sidebar-contents template part and use it for single sidebar layout ([#276](#276)) ([488e43c](488e43c)) * add support for yoast blocks (faq, how-to) ([#241](#241)) ([d63260a](d63260a)) * add support for yoast breadcrumbs; move cap styles to subdirectory ([#239](#239)) ([463584e](463584e)) * **author-list:** add block styles ([#250](#250)) ([7acd4a3](7acd4a3)) * **breadcrumbs:** ensure text and link colors are supported ([#240](#240)) ([fb3e939](fb3e939)) * **button:** x-small size adjust min-height and border-radius for consistency with newspack-icon ([#271](#271)) ([5fa1f7c](5fa1f7c)) * **footer:** add new pattern and adjust style 4 ([#269](#269)) ([9e826e9](9e826e9)) * **footer:** update credits ([#278](#278)) ([cec87b1](cec87b1)) * **homepage-articles:** add transition to links ([#234](#234)) ([bdf924a](bdf924a)) * **navigation:** update hover style; remove underline and use color-mix instead ([#247](#247)) ([08994a3](08994a3)) * **overlay:** update close button to 64px tall/wide ([#233](#233)) ([39e9dad](39e9dad)) * **patterns:** add 1 new footer pattern ([#257](#257)) ([758e38c](758e38c)) * **patterns:** improve columns preview; add 25/25/25/25 ([#275](#275)) ([0f5427f](0f5427f)) * **post-carousel:** update style ([#249](#249)) ([d87ac30](d87ac30)) * **post-meta:** update hover state ([#251](#251)) ([b1ba1d5](b1ba1d5)) * reorganise header parts ([#253](#253)) ([14ee203](14ee203)) * **search:** update template part to match pagination with archive ([#279](#279)) ([6e3da20](6e3da20)) * simplify home and index templates to match page and archive; remove archive pattern ([#277](#277)) ([5d09c60](5d09c60)) * update comments elements names ([#235](#235)) ([27e963e](27e963e)) * update mobile menu elements names ([#237](#237)) ([a1f5070](a1f5070)) * update post header patterns; add wide option ([#267](#267)) ([1bd4d76](1bd4d76)) * update post header to use pattern; introduce sidebar post template ([#262](#262)) ([ff015a1](ff015a1)) * update post-content; adjust align left/right position ([#280](#280)) ([b1a5378](b1a5378)) * update search elements names ([#236](#236)) ([0f926d2](0f926d2))
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Similar to #254 but this time for the mobile header
screencast.mp4
How to test the changes in this Pull Request:
See #254
Other information: