Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add backward compatibility with classic theme #176

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR matches the old variables (primary, secondary, etc...) with the new ones (accent, accent-2, etc...). It also makes sure normal and huge font-sizes are rendered correctly.

Note: In the editor the colour swatch or font-size will return empty. This is normal/expected.

How to test the changes in this Pull Request:

  1. Using the Classic Theme, create a page with a bunch of groups, columns, etc... with colours, background colours, borders
  2. Also play with font-sizes
  3. Switch to the Block Theme (trunk)
  4. You should not see your primary colour etc...
  5. Switch to this branch and refresh page

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot self-assigned this Jun 11, 2024
@thomasguillot thomasguillot requested a review from a team as a code owner June 11, 2024 15:45
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I switch to this branch, I see the styles that were added in the classic theme

@thomasguillot thomasguillot merged commit 01b95f2 into trunk Jul 2, 2024
5 checks passed
@thomasguillot thomasguillot deleted the add/classic-theme-support branch July 2, 2024 15:53
@matticbot
Copy link

🎉 This PR is included in version 1.11.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 5, 2024
# [1.11.0-alpha.1](v1.10.0...v1.11.0-alpha.1) (2024-07-05)

### Bug Fixes

* buttons without class; outline border-color ([#212](#212)) ([3f9342b](3f9342b))
* cover alignfull as last-child should not have margin with footer ([#218](#218)) ([dcd96a5](dcd96a5))
* homepage articles row gap; use custom spacing ([#223](#223)) ([300920e](300920e))
* variables typo ([#229](#229)) ([9bbd305](9bbd305))

### Features

* add author-profile styles ([#209](#209)) ([5d81cc1](5d81cc1))
* add backward compatibility with classic theme ([#176](#176)) ([01b95f2](01b95f2))
* add generic desktop-only and mobile-only classes ([#222](#222)) ([dc58d55](dc58d55))
* add no-title page template; reduce gap with header when no-title ([#219](#219)) ([3824676](3824676))
* **search-overlay:** update search input height ([#224](#224)) ([2cb32ad](2cb32ad))
* tweak animations ([#231](#231)) ([d475cc3](d475cc3))
* update desktop-header spacings ([#208](#208)) ([a7ba9b0](a7ba9b0))
* update header mobile and desktop spacing; introduce is-position ([#221](#221)) ([a92f8fa](a92f8fa))
* update overlay ([#220](#220)) ([457347b](457347b))
* update search overlay ([#215](#215)) ([27699f8](27699f8))
* update sticky position to support mobile or desktop only ([#225](#225)) ([df1158e](df1158e))
* update various widths and spacings to use variables ([#227](#227)) ([00dcc02](00dcc02))
* use patterns instead of template parts for author-bio ([#210](#210)) ([147c315](147c315))
matticbot pushed a commit that referenced this pull request Jul 15, 2024
# [1.11.0](v1.10.0...v1.11.0) (2024-07-15)

### Bug Fixes

* buttons without class; outline border-color ([#212](#212)) ([3f9342b](3f9342b))
* cover alignfull as last-child should not have margin with footer ([#218](#218)) ([dcd96a5](dcd96a5))
* homepage articles row gap; use custom spacing ([#223](#223)) ([300920e](300920e))
* variables typo ([#229](#229)) ([9bbd305](9bbd305))

### Features

* add author-profile styles ([#209](#209)) ([5d81cc1](5d81cc1))
* add backward compatibility with classic theme ([#176](#176)) ([01b95f2](01b95f2))
* add generic desktop-only and mobile-only classes ([#222](#222)) ([dc58d55](dc58d55))
* add no-title page template; reduce gap with header when no-title ([#219](#219)) ([3824676](3824676))
* **search-overlay:** update search input height ([#224](#224)) ([2cb32ad](2cb32ad))
* tweak animations ([#231](#231)) ([d475cc3](d475cc3))
* update desktop-header spacings ([#208](#208)) ([a7ba9b0](a7ba9b0))
* update header mobile and desktop spacing; introduce is-position ([#221](#221)) ([a92f8fa](a92f8fa))
* update overlay ([#220](#220)) ([457347b](457347b))
* update search overlay ([#215](#215)) ([27699f8](27699f8))
* update sticky position to support mobile or desktop only ([#225](#225)) ([df1158e](df1158e))
* update various widths and spacings to use variables ([#227](#227)) ([00dcc02](00dcc02))
* use patterns instead of template parts for author-bio ([#210](#210)) ([147c315](147c315))
@matticbot
Copy link

🎉 This PR is included in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants