Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(post-comments): improve style for pingback and trackbacks #162

Merged
merged 1 commit into from
May 30, 2024
Merged

feat(post-comments): improve style for pingback and trackbacks #162

merged 1 commit into from
May 30, 2024

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR slightly tweaks the comments but more importantly, it adds styles for pingback/trackbacks

Partially fixes #146

How to test the changes in this Pull Request:

  1. Make sure you have the imported the Theme Unit Test
  2. Navigate to a post with comments, and trackbacks
  3. Check the comments
  4. Switch to this branch
  5. Recheck

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot self-assigned this May 29, 2024
@thomasguillot thomasguillot requested a review from a team as a code owner May 29, 2024 15:48
laurelfulford
laurelfulford approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thanks Thomas! 🙌

Edited to add because I mashed the button too fast -- while testing I did notice an small issue with the Paul styles unrelated to anything here: the inputs (at least textarea) aren't visible against the background until you focus on them:

image

This probably works better in some areas if intentional, but caught me off guard here -- let me know if I should spin up a separate issue for this!

@thomasguillot
Copy link
Contributor Author

I haven't tested Paul for a long time, the json file is probably outdated.

@thomasguillot thomasguillot merged commit 1f7cc01 into trunk May 30, 2024
8 checks passed
@thomasguillot thomasguillot deleted the update/post-comments branch May 30, 2024 16:25
matticbot pushed a commit that referenced this pull request May 31, 2024
@semantic-release-bot @matticbot
chore(release): 1.9.0-alpha.1 [skip ci]
7169505 
# [1.9.0-alpha.1](v1.8.0...v1.9.0-alpha.1) (2024-05-31)

### Bug Fixes

* disqus captcha cropping ([#163](#163)) ([93d6d06](93d6d06))

### Features

* add basic styles for input submit ([#157](#157)) ([df2ace1](df2ace1))
* add blank page template ([#158](#158)) ([b56d2b6](b56d2b6))
* add jetpack compatibility file ([#160](#160)) ([dce13dd](dce13dd))
* add post-meta pattern ([#148](#148)) ([67d3860](67d3860))
* add specific styles for media & text block ([#154](#154)) ([99e77c9](99e77c9))
* add support for jetpack top posts ([#161](#161)) ([492538b](492538b))
* add support for table block ([#166](#166)) ([1b3d85f](1b3d85f))
* **post-comments:** improve style for pingback and trackbacks ([#162](#162)) ([1f7cc01](1f7cc01))
@matticbot
Copy link

🎉 This PR is included in version 1.9.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jun 12, 2024
@semantic-release-bot @matticbot
chore(release): 1.9.0 [skip ci]
08cb278 
# [1.9.0](v1.8.0...v1.9.0) (2024-06-12)

### Bug Fixes

* disqus captcha cropping ([#163](#163)) ([93d6d06](93d6d06))

### Features

* add basic styles for input submit ([#157](#157)) ([df2ace1](df2ace1))
* add blank page template ([#158](#158)) ([b56d2b6](b56d2b6))
* add jetpack compatibility file ([#160](#160)) ([dce13dd](dce13dd))
* add post-meta pattern ([#148](#148)) ([67d3860](67d3860))
* add specific styles for media & text block ([#154](#154)) ([99e77c9](99e77c9))
* add support for jetpack top posts ([#161](#161)) ([492538b](492538b))
* add support for table block ([#166](#166)) ([1b3d85f](1b3d85f))
* **post-comments:** improve style for pingback and trackbacks ([#162](#162)) ([1f7cc01](1f7cc01))
@matticbot
Copy link

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelfulford laurelfulford laurelfulford approved these changes

Assignees

@thomasguillot thomasguillot

Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comments sidebar: improvements required
3 participants
@thomasguillot @matticbot @laurelfulford