Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct annoying search preview issue #147

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: correct annoying search preview issue #147

merged 1 commit into from
May 16, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR fixes an editor preview issue with the search overlay. The fixed position coming from the theme was getting overridden by more specific editor styles.

How to test the changes in this Pull Request:

  1. Edit one of the full-page templates; note how dang tall the header is:

image

  1. Apply this PR and run npm run build.
  2. Confirm the header now looks closer to the front-end in the editor:

image

  1. View the front end and test the search to confirm it still works.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from a team as a code owner May 15, 2024 17:03
thomasguillot
thomasguillot approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@thomasguillot thomasguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice one! This was bugging me! 🚢

@thomasguillot
Copy link
Contributor

Merging this now on behalf of @laurelfulford because this is REALLY bugging me 🤣

@thomasguillot thomasguillot merged commit 7dde399 into trunk May 16, 2024
6 checks passed
@thomasguillot thomasguillot deleted the fix/search-preview branch May 16, 2024 08:40
matticbot pushed a commit that referenced this pull request May 20, 2024
@semantic-release-bot @matticbot
chore(release): 1.8.0-alpha.1 [skip ci]
7e3de4e 
# [1.8.0-alpha.1](v1.7.0...v1.8.0-alpha.1) (2024-05-20)

### Bug Fixes

* correct annoying search preview issue ([#147](#147)) ([7dde399](7dde399))

### Features

* add comments sidebar ([#135](#135)) ([5ffcd15](5ffcd15))
* add support for co-author plus blocks ([#139](#139)) ([14e2893](14e2893))
* update search templates ([#137](#137)) ([5e89534](5e89534))
@matticbot
Copy link

🎉 This PR is included in version 1.8.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@laurelfulford
Copy link
Contributor Author

Haha thanks for merging this, @thomasguillot! I JUST remembered it and went to check it 🤦‍♀️

matticbot pushed a commit that referenced this pull request May 28, 2024
@semantic-release-bot @matticbot
chore(release): 1.8.0 [skip ci]
9967802 
# [1.8.0](v1.7.0...v1.8.0) (2024-05-28)

### Bug Fixes

* correct annoying search preview issue ([#147](#147)) ([7dde399](7dde399))

### Features

* add comments sidebar ([#135](#135)) ([5ffcd15](5ffcd15))
* add support for co-author plus blocks ([#139](#139)) ([14e2893](14e2893))
* update search templates ([#137](#137)) ([5e89534](5e89534))
@matticbot
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasguillot thomasguillot thomasguillot approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @thomasguillot @matticbot