Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update desktop header template part #106

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

I've updated the template part, mainly:

  • I removed site title and tagline. I expect our publishers to have a site logo and I can find a good reason why they'd want logo + site title.
  • Most of the blocks have been locked
  • I created a new custom css class to add a min-height to the primary navigation (36px, to match the search button)
  • Font-weight for the navigation block has been changed to 600.
  • I fixed the donate button style, it was broken since I removed the button styles in feat: update button style #103

How to test the changes in this Pull Request:

  1. Fresh install
  2. Check your header
  3. Switch to this branch
  4. Check again

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and was able to confirm all of the listed changes.

Before:
Screenshot 2024-01-19 at 11 22 48

After:
Screenshot 2024-01-19 at 11 20 46

One note is, I wasn't sure exactly how the Donate button was broken prior to these changes since I only noticed a width reduction. But in any case, will go ahead with a thumbs up since it still looks good on my end 👍

@thomasguillot
Copy link
Contributor Author

Thank you, @chickenn00dle 😊
I should have been more precise with the donate button, it had the wrong width/paddings.

@thomasguillot thomasguillot merged commit b5d45ba into master Jan 19, 2024
3 checks passed
@thomasguillot thomasguillot deleted the update/desktop-header-part branch January 19, 2024 17:06
matticbot pushed a commit that referenced this pull request Jan 26, 2024
# [1.5.0-alpha.1](v1.4.0...v1.5.0-alpha.1) (2024-01-26)

### Bug Fixes

* parenthesis ([a0c485f](a0c485f))
* remove link from post date archive ([#90](#90)) ([d08ba5e](d08ba5e))

### Features

* add 2x-small font size ([#102](#102)) ([cb17fdc](cb17fdc))
* add new "Paul" style ([#88](#88)) ([5605dab](5605dab))
* update archive template ([#89](#89)) ([3c8556d](3c8556d))
* update button block ([#91](#91)) ([b66f75a](b66f75a))
* update button style ([#103](#103)) ([4b686f9](4b686f9))
* update desktop header template part ([#106](#106)) ([b5d45ba](b5d45ba))
* update footer part and lock blocks ([#105](#105)) ([0490354](0490354))
* update grid and typography ([64c70d7](64c70d7))
* update grid and typography ([f5073ef](f5073ef))
* update svg icons and search overlay ([#111](#111)) ([9ee5b6a](9ee5b6a))
* update the query pagination block ([#93](#93)) ([03e7fb6](03e7fb6))
@matticbot
Copy link

🎉 This PR is included in version 1.5.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 6, 2024
# [1.5.0](v1.4.0...v1.5.0) (2024-02-06)

### Bug Fixes

* parenthesis ([a0c485f](a0c485f))
* remove link from post date archive ([#90](#90)) ([d08ba5e](d08ba5e))

### Features

* add 2x-small font size ([#102](#102)) ([cb17fdc](cb17fdc))
* add new "Paul" style ([#88](#88)) ([5605dab](5605dab))
* update archive template ([#89](#89)) ([3c8556d](3c8556d))
* update button block ([#91](#91)) ([b66f75a](b66f75a))
* update button style ([#103](#103)) ([4b686f9](4b686f9))
* update desktop header template part ([#106](#106)) ([b5d45ba](b5d45ba))
* update footer part and lock blocks ([#105](#105)) ([0490354](0490354))
* update grid and typography ([64c70d7](64c70d7))
* update grid and typography ([f5073ef](f5073ef))
* update svg icons and search overlay ([#111](#111)) ([9ee5b6a](9ee5b6a))
* update the query pagination block ([#93](#93)) ([03e7fb6](03e7fb6))
@matticbot
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants