Newsletter: Update newsletter copies when the site is not public.

[spsiddarthan]

Fixes #40485

When a simple/atomic site is in the 'coming soon' mode, we incorrectly display the 'This post will be sent to 1 subscriber.' copy. I have attached the screenshot of the issue and the steps to reproduce it.

Proposed changes:

• Update the copy to say that we won't be sending the emails if the site is in the 'Coming Soon' mode.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Simple sites/Atomic sites:

To setup, run bin/jetpack-downloader test jetpack fix/newsletter-editor-copies-for-coming-soon on the sandbox and sandbox your test simple site. Install the Jetpack Beta plugin on your Atomic site and run this branch to test atomic sites.

• On a test simple site that hasn't been launched yet, write a new post and open the newsletter panel. You will see this.

• Launch the site, write a new post and open the newsletter panel. You will see this.

• After the post is published, if you refresh the page and visit the newsletter panel of the post, you will see this.

• Now put the site in coming soon mode again. If repeat the above step, you will see this

Jetpack Sites:

• This change won't affect jetpack sites, just sanity test to ensure you can see the newsletter panel in the editor sidebar.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/newsletter-editor-copies-for-coming-soon branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/newsletter-editor-copies-for-coming-soon
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for February 4, 2025 (scheduled code freeze on February 4, 2025).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/extensions/shared/memberships/subscribers-affirmation.js	0/64 (0.00%)	0.00%	2 💔

Full summary · PHP report · JS report

[allilevine]

I tested Simple, Atomic, and Jetpack and I saw the correct message:

Just an observation: I find it strange that we don't show historical data when editing past posts, like whether it was actually sent. It seems like it's based on the state of the site now (coming soon or not, and what the subscriber count is now).

[spsiddarthan]

I find it strange that we don't show historical data when editing past posts, like whether it was actually sent. It seems like it's based on the state of the site now (coming soon or not, and what the subscriber count is now).

Good point, perhaps we should update the state in post meta. Perhaps this is worth a p2 post to discuss on how to approach this, I will make sure to write one today or tomorrow.