Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Likes block: allow hiding avatars #40282

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Conversation

simison
Copy link
Member

@simison simison commented Nov 20, 2024

Related to #40276

Depends on D165404-code (DO NOT MERGE before backend!)

Proposed changes:

  • Add ability to hide avatars in Likes block

This is backawards compatible as old blocks won't have setting, and in Gutenberg "default" value means no attribute is stored in block markup. Hence no deprecation transforms needed.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply diff
  • Add block to a page
  • Disable avatar setting
  • Avatars should be gone in editor and the site

@github-actions github-actions bot added [Block] Like [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Nov 20, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@simison simison requested review from georgestephanis and a team November 20, 2024 19:23
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/likes-hide-avatars branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/likes-hide-avatars
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@georgestephanis
Copy link
Member

This is also contingent on the upstream phab diff D165404 merging to wpcom.

@jeherve jeherve added [Feature] Likes [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Nov 21, 2024
@coder-karen
Copy link
Contributor

I feel I'm missing a step testing-wise for Jetpack self-hosted sites. I've got a sandboxed JN site, applied the diff, also added widgets.wp.com to my hosts file.

I can 'like' the post / page via the like block and see no avatar (yet it shows as liked). However the toggle state in the editor won't change, though the initial toggle click (followed by pressing save) does allow me to see my avatar when clicking like on the front-end now.

@simison
Copy link
Member Author

simison commented Nov 21, 2024

However the toggle state in the editor won't change

I'm having the same issue, and I don't get what's missing. 🤔 My local Jetpack isn't working now so having a bit hard time to develop, but I'll get this going and can ping when it's no longer in progress.

@simison
Copy link
Member Author

simison commented Nov 22, 2024

@coder-karen good for another look now!

Attribute handling wasn't great in this block so I did it like it's done with our other blocks.

@simison simison added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. DO NOT MERGE don't merge it! and removed [Status] In Progress labels Nov 22, 2024
@coder-karen
Copy link
Contributor

Yes it works now, thanks!

I tested on Simple and self-hosted, I did notice on both that I had issues liking or unliking if avatars were disabled (cannot read properties of undefined (reading 'querySelector')). It worked fine if Avatars were enabled.

Also if I have like buttons added to the post /page via the Jetpack sharing settings, that will show avatars when the like block doesn't. I'm guessing that's expected at the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Like DO NOT MERGE don't merge it! [Feature] Likes [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants