-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Likes block: allow hiding avatars #40282
base: trunk
Are you sure you want to change the base?
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
This is also contingent on the upstream phab diff D165404 merging to wpcom. |
b2011b3
to
5e46d3d
Compare
I feel I'm missing a step testing-wise for Jetpack self-hosted sites. I've got a sandboxed JN site, applied the diff, also added widgets.wp.com to my hosts file. I can 'like' the post / page via the like block and see no avatar (yet it shows as liked). However the toggle state in the editor won't change, though the initial toggle click (followed by pressing save) does allow me to see my avatar when clicking like on the front-end now. |
I'm having the same issue, and I don't get what's missing. 🤔 My local Jetpack isn't working now so having a bit hard time to develop, but I'll get this going and can ping when it's no longer in progress. |
5e46d3d
to
9df1308
Compare
@coder-karen good for another look now! Attribute handling wasn't great in this block so I did it like it's done with our other blocks. |
Yes it works now, thanks! I tested on Simple and self-hosted, I did notice on both that I had issues liking or unliking if avatars were disabled ( Also if I have like buttons added to the post /page via the Jetpack sharing settings, that will show avatars when the like block doesn't. I'm guessing that's expected at the moment? |
Related to #40276
Depends on D165404-code (DO NOT MERGE before backend!)
Proposed changes:
This is backawards compatible as old blocks won't have setting, and in Gutenberg "default" value means no attribute is stored in block markup. Hence no deprecation transforms needed.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: