Add new external media endpoint

.github/files/coverage-munger/process-coverage.sh

@@ -17,27 +17,39 @@ echo '::endgroup::'
 TMP_DIR=$( mktemp -d )
 trap 'rm -rf "$TMP_DIR"' exit
 
-echo "::group::Combining PHP coverage"
-composer --working-dir="$BASE" update
-"$BASE"/vendor/bin/phpcov merge --php artifacts/php-combined.cov coverage
-perl -i -pwe 'BEGIN { $prefix = shift; $prefix=~s!/*$!/!; $re = qr/\Q$prefix\E/; $l = length( $prefix ); } s!s:(\d+):"$re! sprintf( qq(s:%d:"), $1 - $l ) !ge' "$GITHUB_WORKSPACE" artifacts/php-combined.cov
-echo '::endgroup::'
-
-echo "::group::Combining JS coverage"
-pnpm --filter=jetpack-gh-config-munger exec istanbul-merge --out "$PWD"/artifacts/js-combined.json $( find "$PWD/coverage" -name '*.json' )
-perl -i -pwe 'BEGIN { $prefix = shift; $prefix=~s!/*$!/!; $re = qr/\Q$prefix\E/; } s!"$re!"!g' "$GITHUB_WORKSPACE" artifacts/js-combined.json
-echo '::endgroup::'
-
-echo "::group::Creating PHP coverage summary"
-"$BASE"/extract-php-summary-data.php artifacts/php-combined.cov > "$TMP_DIR/php-summary.tsv"
-echo '::endgroup::'
+TMP=$( find "$PWD/coverage" -name '*.cov' )
+if [[ -n "$TMP" ]]; then
+	echo "::group::Combining PHP coverage"
+	composer --working-dir="$BASE" update
+	"$BASE"/vendor/bin/phpcov merge --php artifacts/php-combined.cov coverage
+	perl -i -pwe 'BEGIN { $prefix = shift; $prefix=~s!/*$!/!; $re = qr/\Q$prefix\E/; $l = length( $prefix ); } s!s:(\d+):"$re! sprintf( qq(s:%d:"), $1 - $l ) !ge' "$GITHUB_WORKSPACE" artifacts/php-combined.cov
+	echo '::endgroup::'
+
+	echo "::group::Creating PHP coverage summary"
+	"$BASE"/extract-php-summary-data.php artifacts/php-combined.cov > "$TMP_DIR/php-summary.tsv"
+	echo '::endgroup::'
+else
+	echo "No PHP coverage files found!"
+	touch "$TMP_DIR/php-summary.tsv"
+fi
 
-echo "::group::Creating JS coverage summary"
-mkdir "$TMP_DIR/js"
-cp artifacts/js-combined.json "$TMP_DIR/js"
-pnpm --filter=jetpack-gh-config-munger exec nyc report --no-exclude-after-remap --report-dir="$TMP_DIR" --temp-dir="$TMP_DIR/js" --reporter=json-summary
-jq -r 'to_entries[] | select( .key != "total" ) | [ .key, .value.lines.total, .value.lines.covered ] | @tsv' "$TMP_DIR/coverage-summary.json" > "$TMP_DIR/js-summary.tsv"
-echo '::endgroup::'
+TMP=$( find "$PWD/coverage" -name '*.json' )
+if [[ -n "$TMP" ]]; then
+	echo "::group::Combining JS coverage"
+	pnpm --filter=jetpack-gh-config-munger exec istanbul-merge --out "$PWD"/artifacts/js-combined.json $TMP
+	perl -i -pwe 'BEGIN { $prefix = shift; $prefix=~s!/*$!/!; $re = qr/\Q$prefix\E/; } s!"$re!"!g' "$GITHUB_WORKSPACE" artifacts/js-combined.json
+	echo '::endgroup::'
+
+	echo "::group::Creating JS coverage summary"
+	mkdir "$TMP_DIR/js"
+	cp artifacts/js-combined.json "$TMP_DIR/js"
+	pnpm --filter=jetpack-gh-config-munger exec nyc report --no-exclude-after-remap --report-dir="$TMP_DIR" --temp-dir="$TMP_DIR/js" --reporter=json-summary
+	jq -r 'to_entries[] | select( .key != "total" ) | [ .key, .value.lines.total, .value.lines.covered ] | @tsv' "$TMP_DIR/coverage-summary.json" > "$TMP_DIR/js-summary.tsv"
+	echo '::endgroup::'
+else
+	echo "No JS coverage files found!"
+	touch "$TMP_DIR/js-summary.tsv"
+fi
 
 echo "::group::Combining coverage summaries"
 sort "$TMP_DIR/php-summary.tsv" "$TMP_DIR/js-summary.tsv" > artifacts/summary.tsv

.github/files/generate-ci-matrix.php

@@ -65,29 +65,18 @@
 		'script'  => 'test-php',
 		'php'     => $php,
 		'wp'      => 'latest',
-		'timeout' => 20, // 2023-08-17: Successful runs seem to take up to ~12 minutes.
+		'timeout' => 20, // 2024-11-12: Successful runs seem to take up to ~7 minutes.
 	);
 }
 
-// TODO: When WordPress 6.5 is no longer supported, this can be removed. Runs too slow on ubuntu-24.04 (ubuntu-latest).
-$matrix[] = array(
-	'name'                => 'PHP tests: PHP 7.0 WP previous',
-	'runner'              => 'ubuntu-22.04',
-	'script'              => 'test-php',
-	'php'                 => '7.0',
-	'wp'                  => 'previous',
-	'timeout'             => 20, // 2023-08-17: Successful runs seem to take up to ~12 minutes.
-	'force-package-tests' => true,
-);
-
 foreach ( array( 'previous', 'trunk' ) as $wp ) {
 	$phpver   = $versions['PHP_VERSION'];
 	$matrix[] = array(
 		'name'    => "PHP tests: PHP {$phpver} WP $wp",
 		'script'  => 'test-php',
 		'php'     => $phpver,
 		'wp'      => $wp,
-		'timeout' => 15, // 2021-01-18: Successful runs seem to take ~8 minutes for the 7.4 trunk run, ~5.5-6 for 7.x and 8.0.
+		'timeout' => 15, // 2024-11-12: Successful runs seem to take ~7 minutes with PHP 8.2.
 	);
 }
 
@@ -115,15 +104,15 @@
 $matrix[] = array(
 	'name'    => 'JS tests',
 	'script'  => 'test-js',
-	'timeout' => 15, // 2021-01-18: Successful runs seem to take ~5 minutes.
+	'timeout' => 15, // 2024-11-12: Successful runs seem to take ~5 minutes.
 );
 
 // Add Coverage tests.
 $matrix[] = array(
 	'name'    => 'Code coverage',
 	'script'  => 'test-coverage',
 	'wp'      => 'latest',
-	'timeout' => 40, // 2024-10-30: Successful runs seem to take ~30 minutes. We'll need to improve that.
+	'timeout' => 40, // 2024-11-12: Successful runs seem to take ~14 minutes.
 );
 
 // END matrix definitions.

.github/files/phpcompatibility-dev-phpcs.xml

@@ -8,8 +8,5 @@
 	<rule ref="PHPCompatibilityWP">
 		<!-- Doesn't hurt anything, earlier versions ignore attributes. -->
 		<exclude name="PHPCompatibility.Attributes.NewAttributes.Found" />
-
-		<!-- We're not ready for 8.4 yet. Hopefully https://core.trac.wordpress.org/ticket/58719 will happen before we are. -->
-		<exclude name="PHPCompatibility.FunctionDeclarations.RemovedImplicitlyNullableParam.Deprecated" />
 	</rule>
 </ruleset>

.github/files/select-wordpress-tag.sh

@@ -20,7 +20,7 @@ case "$WP_BRANCH" in
 	previous)
 		# We hard-code the version here because there's a time near WP releases where
 		# we've dropped the old 'previous' but WP hasn't actually released the new 'latest'
-		WORDPRESS_TAG=6.5
+		WORDPRESS_TAG=6.6
 		;;
 	*)
 		echo "Unrecognized value for WP_BRANCH: $WP_BRANCH" >&2

.github/versions.sh

@@ -5,5 +5,5 @@ NODE_VERSION=22.9.0
 PNPM_VERSION=9.3.0
 
 # Other useful version numbers.
-MIN_PHP_VERSION=7.0
+MIN_PHP_VERSION=7.2
 MAX_PHP_VERSION=8.3

.github/workflows/linting.yml

@@ -171,7 +171,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-versions: [ '7.0', '7.2', '7.4', '8.0', '8.1', '8.2', '8.3' ]
+        php-versions: [ '7.2', '7.4', '8.0', '8.1', '8.2', '8.3' ]
         experimental: [ false ]
 
     steps:

.github/workflows/tests.yml

@@ -251,7 +251,7 @@ jobs:
       - name: Process coverage results
         env:
           CHANGED: ${{ steps.changed.outputs.projects }}
-        if: matrix.script == 'test-coverage'
+        if: matrix.script == 'test-coverage' && always()
         run: .github/files/coverage-munger/process-coverage.sh
 
       - name: Check for artifacts

.phan/config.base.php

@@ -268,11 +268,5 @@ function make_phan_config( $dir, $options = array() ) {
 		$config['minimum_target_php_version'] = $m[1];
 	}
 
-	// Disable PhanDeprecatedImplicitNullableParam if still supporting PHP 7.0
-	// @todo Remove this once we drop PHP 7.0 support everywhere.
-	if ( isset( $config['minimum_target_php_version'] ) && version_compare( $config['minimum_target_php_version'], '7.1.0', '<' ) ) {
-		$config['suppress_issue_types'][] = 'PhanDeprecatedImplicitNullableParam';
-	}
-
 	return $config;
 }

.phpcs.config.xml

@@ -2,8 +2,8 @@
 <!-- This file configures everything except the list of rules. -->
 <!-- The separation is so .github/files/phpcompatibility-dev-phpcs.xml can use the same config with a different rule set. -->
 <ruleset>
-	<config name="minimum_supported_wp_version" value="6.5" />
-	<config name="testVersion" value="7.0-"/>
+	<config name="minimum_supported_wp_version" value="6.6" />
+	<config name="testVersion" value="7.2-"/>
 
 	<!-- Use our custom filter for `.phpcsignore` and `.phpcs.dir.xml` support. -->
 	<arg name="filter" value="vendor/automattic/jetpack-phpcs-filter/src/PhpcsFilter.php" />

composer.json

@@ -15,8 +15,8 @@
 		"phan/phan": "^5.4",
 		"php-parallel-lint/php-parallel-lint": "^1.4.0",
 		"php-stubs/woocommerce-stubs": ">=8.7",
-		"php-stubs/wordpress-stubs": ">=6.5",
-		"php-stubs/wordpress-tests-stubs": ">=6.5",
+		"php-stubs/wordpress-stubs": ">=6.6",
+		"php-stubs/wordpress-tests-stubs": ">=6.6",
 		"php-stubs/wp-cli-stubs": "^2.10",
 		"sirbrillig/phpcs-changed": "^2.11.5",
 		"squizlabs/php_codesniffer": "^3.6.2"

docs/development-environment.md

@@ -384,9 +384,9 @@ We strongly recommend that you install tools to review your code in your IDE. It
 	composer phpcs:lint
 	```
 
-* ### Checking Jetpack's PHP for compatibility with different versions of PHP since 7.0
+* ### Checking Jetpack's PHP for compatibility with different versions of PHP
 
-	We have a handy `composer` script that will just run the PHP CodeSniffer `PHPCompatibilityWP` ruleset checking for code not compatible with PHP 7.0
+	We have a handy `composer` script that will just run the PHP CodeSniffer `PHPCompatibilityWP` ruleset checking for code not compatible with supported PHP versions:
 
 	```sh
 	composer phpcs:compatibility

docs/monorepo.md

@@ -41,7 +41,7 @@ All GitHub Actions configuration for the monorepo, including CI, lives in `.gith
 
 ## Compatibility
 
-All projects should be compatible with PHP versions WordPress supports. That's currently PHP 7.0 to 8.3.
+All projects should be compatible with PHP versions WordPress supports. That's currently PHP 7.2 to 8.3.
 
 ## First Time
 
@@ -266,15 +266,15 @@ If a project contains PHP tests (typically PHPUnit), it must define `.scripts.te
 
 A MySQL database is available if needed; credentials may be found in `~/.my.cnf`. Note that the host must be specified as `127.0.0.1`, as when passed `localhost` PHP will try to connect via a Unix domain socket which is not available in the Actions environment.
 
-Tests are run with a variety of supported PHP versions from 7.0 to 8.3. If you have tests that only need to be run once, run them when `PHP_VERSION` matches that in `.github/versions.sh`.
+Tests are run with a variety of supported PHP versions from 7.2 to 8.3. If you have tests that only need to be run once, run them when `PHP_VERSION` matches that in `.github/versions.sh`.
 
 #### PHP tests for non-plugins
 
 For all project types other than WordPress plugins, the necessary version of PHPUnit and/or any other tools should be pulled in via Composer.
 
 We currently make use of the following packages in testing; it's encouraged to use these rather than introducing other tools that serve the same purpose.
 
-* [yoast/phpunit-polyfills](https://packagist.org/packages/yoast/phpunit-polyfills) supplies polyfills for compatibility with PHPUnit 6.5 to 9.0, to support PHP 7.0 to 8.3.
+* [yoast/phpunit-polyfills](https://packagist.org/packages/yoast/phpunit-polyfills) supplies polyfills for compatibility with PHPUnit 8.5 to 9.6, to support PHP 7.2 to 8.3.
   * Do not use `Yoast\PHPUnitPolyfills\TestCases\TestCase` or `Yoast\PHPUnitPolyfills\TestCases\XTestCase`. Just use the `@before`, `@after`, `@beforeClass`, and `@afterClass` annotations directly.
 * PHPUnit's built-in mocking is used for class mocks.
 * [brain/monkey](https://packagist.org/packages/brain/monkey) is used for mocking functions, and can also provide some functions for minimal WordPress compatibility.
@@ -315,6 +315,53 @@ For JS tests, you'll probably have a `test` script in package.json that runs `je
 
 There's no need to be concerned about collisions with other projects' coverage files, a separate directory is used per project. The coverage files are also automatically copied to `ARTIFACTS_DIR`.
 
+If you want to generate coverage locally, e.g. with `jetpack test coverage`, note that generating PHP coverage requires the [pcov](https://pecl.php.net/package/pcov) or [xdebug](https://pecl.php.net/package/xdebug) extensions. We use `pcov` for the CI runs; results from `xdebug` may be slightly different.
+
+<details><summary>Installing the PHP pcov extension on Linux</summary>
+
+On most Linux distributions, you can install the PHP pcov extension using your package manager:
+
+- For Ubuntu/Debian-based systems:
+  ```
+  sudo apt-get install php8.2-pcov
+  ```
+- For Arch Linux:
+  Install the AUR package "php-pcov" from https://aur.archlinux.org/packages/php-pcov
+
+For other Linux distributions, consult your package manager's documentation or consider compiling from source.
+
+</details>
+
+Mac users have reported having trouble installing the PHP pcov extension. See the dropdown below for Mac-specific instructions.
+
+<details><summary>Installing the PHP pcov extension on Mac</summary>
+
+This assumes you have PHP installed via Homebrew, e.g. you've done `brew install [email protected]`.
+
+1. First, check whether pcov is already installed by running `php --ri pcov`. If it prints something like this, you should already be good:
+   ```
+   pcov
+
+   PCOV support => Enabled
+   PCOV version => 1.0.11
+   pcov.directory => /some/path/
+   pcov.exclude => none
+   pcov.initial.memory => 65336 bytes
+   pcov.initial.files => 64
+   ```
+2. You may need to `brew install pkg-config zlib` to install some necessary dependencies.
+3. Update the list of available extensions: `pecl channel-update pecl.php.net`
+4. Build the extension: `pecl install pcov`
+   - If the build process fails due to mkdir errors with the pecl directory, you might try `mkdir -p /opt/homebrew/lib/php/pecl` and running the install again.
+5. You may also need to tell PHP where to find the newly-installed extension.
+   1. Run `pecl config-get ext_dir` to find where pecl installs extensions.
+   2. Run `php -r 'echo ini_get( "extension_dir" ) . "\n";'` to find where PHP currently expects extensions to live.
+   3. If those are the same, great! If not, you have two options:
+      * If PHP's current directory is empty, you could find your `php.ini` file (`php --ini`) and change `extension_dir` to pecl's location.
+      * Or else, pecl probably added `extension=pcov.so` to an ini file somewhere. You could change the `pcov.so` value to be the full path inside pecl's directory.
+
+</details>
+
 ## Mirror repositories
 
 Most projects in the monorepo should have a mirror repository holding a built version of the project, ready for deployment. Follow these steps to create the mirror repo and configure the monorepo tooling to push to it.

docs/testing/regression-checklist/regression-checklist.md

@@ -21,7 +21,7 @@ NOTE: it might become outdated, so it could be a good idea to generate this file
 
 ### PHP versions(Low)
 
-- 7.0 - current
+- 7.2 - current
 
 ### Hosting providers(High)