-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds base ESLint configuration to the wpcomsh plugin. #39275
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks!
A few things inline, although some of them probably don't need any action.
@@ -0,0 +1,5 @@ | |||
# Not loaded by default eslint, but we use tools/js-tools/load-eslint-ignore.js in .eslintrc to pull it in. | |||
|
|||
/tests/e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually we probably should lint this, but OK with me if we do that as a followup.
/custom-colors/js/jquery.spin.js | ||
/custom-colors/js/spin.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we get around to setting up a webpack build for the scripts here in some future PR, we could also look at whether there's an npm package we could use instead of copy-pasting these in.
The spin.js
looks like it's probably an old version of https://www.npmjs.com/package/spin.js.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the one remaining lint error.
* Added a base JS eslint config. * ESLint fixes for classic-background-stats.js * Color.js fixes for eslint. * Eslint fixes for colors-control-beta.js. * Eslint fixes for colors-control.js. * Eslint fixes for colors-theme-preview.js * Eslint auto-fixes for customizer-labels-site-not-launched.js. * Eslint auto-fixes for footer-credit control.js. * Eslint auto-fixes for gifting-banner.js * Eslint fixes for logo tool customizer JS. * Adding eslintignore. * Eslint fixes for music-player.js. * Eslint fixes for tlkio.js * Changeloge. * Properly using ESLintrc file * Update projects/plugins/wpcomsh/custom-colors/js/color.js * Removed unused function, added URI component encoding. * Update projects/plugins/wpcomsh/custom-colors/js/color.js
Fixes ESLint errors when used with base JS ESlint configuration for the Jetpack Monorepo.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: