WordPress.com Features: Calypso Locale Sync from Calypso to wp-admin

[miksansegundo]

Fixes https://github.com/Automattic/dotcom-forge/issues/6812
Related #37316 https://github.com/Automattic/dotcom-forge/issues/7086

Proposed changes:

• Use hook admin_init to check whether the wp-admin locale needs to be synced with Calypso locale
• Duplicate code for locale sync from Admin: Replace user locale with WordPress.com user locale #19525

Note

The masterbar module contains the logic for syncing the Calypso locale in Atomic Default. It's loaded here, only when the navigation redesign flag is disabled.
There is a project in progress that is moving Jetpack Masterbar module to mu-wpcom. See #37277 and read more in pfwV0U-3U-p2

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Go to https://wordpress.com/me/account to change Calypso locale
• Visit any admin page on your atomic site with the nav redesign option flag enabled
• Verify the Calypso locale appears selected in the dropdown in /wp-admin/profile.php
• Verify the locale is applied on the whole UI on the first load

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/sync-wp-admin-with-calypso-locale branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/sync-wp-admin-with-calypso-locale
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Mu Wpcom plugin:

• Next scheduled release: June 4, 2024.
• Scheduled code freeze: May 27, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[DustyReagan]

I added a4a53f8. I thought that would be the easiest way to collaborate, but please feel free to revert it if needed. I'm just sharing ideas. ☺️

I was able to get syncing working both ways with this commit. By skipping all POST requests and skipping GET requests to profile.php?updated=1, I was able to get locale updates on profile.php using #37316 working again. And by forcing a redirect to the current GET request I was able to refresh the language from a Calypso side sync.

The linter is pretty mad at my commit though 😅, so that needs attention. And we need to consider if this approach is brittle. It needs some more thinking. I'm at EOD, so I'll pass it back to you, @miksansegundo. ☺️

[miksansegundo]

I'm testing this again after 1cd341a added the following changes:

• fix linter
• name the function and add more comments
• rename the file to colocate all locale sync logic in the same folder

[miksansegundo]

I raised D148599-code to add the stubs that may be causing the fails on Tests / Static analysis.

However, the tests on that diff didn't pass. I appreciate help with those tests and the pending linter issue. I followed the guide at p81Rsd-1Pn-p2

[lupus2k]

LGTM! 🎉