Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack: Fix various PhanUndefined issues #37344

Merged
merged 5 commits into from
May 14, 2024

Commits on May 10, 2024

  1. Jetpack: Fix various PhanUndefined issues

    Notable changes:
    
    * Remove `Jetpack_User_Agent_Info::is_OperaMobile()`. #16434 removed the
      jetpack-device-detect function this was calling in October 2021, but
      missed this caller.
    * Remove `jetpack_server_sandbox()` and
      `jetpack_server_sandbox_request_parameters()`. Due to a wrong
      namespace in #21128, they'd have thrown fatals since October 2021.
    * Use `$skin` instead of `$upgrader->skin`, it's the same object but not
      typed as a parent class. Should be no change to functionality.
    * Add some missing methods to `WPCOM_JSON_API`.
    * Add some missing abstract methods to SAL_Site, and implement in
      Jetpack_Site.
    * Fix `SAL_Token::is_global()`.
    * Remove `views/admin/deactivation-dialog.php`, unused since #21048 in
      November 2021.
    * Add `@phan-var-force` in a lot of "template" files. I'm not entirely
      happy with this, it pollutes the global scope for any subsequent files
      processed, but short of writing a Phan plugin that somehow adjusts the
      scope for only the file I can't find a better idea.
    anomiex committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e5851cb View commit details
    Browse the repository at this point in the history
  2. Use PHPUnit\Framework\Assert class instead of the function which is i…

    …n a different namespace in old phpunit
    anomiex committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ac638af View commit details
    Browse the repository at this point in the history
  3. Just remove projects/plugins/jetpack/_inc/jetpack-server-sandbox.php …

    …entirely, it hasn't been loaded since 11.4.
    anomiex committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4eee393 View commit details
    Browse the repository at this point in the history
  4. Switch esc_attr for int cast

    anomiex committed May 10, 2024
    Configuration menu
    Copy the full SHA
    6b8ddc4 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    022ddb6 View commit details
    Browse the repository at this point in the history