-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscribe block: adds button-only style #37341
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
e7c5997
to
7d723ea
Compare
7d723ea
to
31080c7
Compare
projects/plugins/jetpack/extensions/blocks/subscriptions/subscriptions.php
Outdated
Show resolved
Hide resolved
"name": "split", | ||
"label": "Split", | ||
"isDefault": true | ||
"name": "button", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could call it button-only
, then we could do $is_style_button_only = get_attribute( $attributes, 'className' ) === 'is-style-button_only';
🤓
projects/plugins/jetpack/extensions/blocks/subscriptions/subscriptions.php
Outdated
Show resolved
Hide resolved
6124d2a
to
042bf44
Compare
Hmm yeah, that's from #37066 I could look into alignments in additional PR; I was thinking to add support for left/right alignment as well. |
d50e3fb
to
004f4e3
Compare
Now just requires D148314-code merged first. |
Supersedes #33921
Resolves #35708
Requires D148314-code merged first.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
In editor, add subscribe block and change style to "button only"
Test with D148314-code and sandbox
subscribe.wordpress.com
Flow now asks for your email.
Test logged in, logged out, already subsribed, etc flows.
Test different styling options from the block sidebar.
On regular subscribe blocks, not filling email still yelds error: