Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe block: adds button-only style #37341

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

simison
Copy link
Member

@simison simison commented May 10, 2024

Supersedes #33921
Resolves #35708

Requires D148314-code merged first.

Proposed changes:

  • Adds "button only" style which basically just hides the email input.
Screenshot 2024-05-13 at 12 15 24

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • In editor, add subscribe block and change style to "button only"

  • Test with D148314-code and sandbox subscribe.wordpress.com

  • Flow now asks for your email.

  • Test logged in, logged out, already subsribed, etc flows.

  • Test different styling options from the block sidebar.

  • On regular subscribe blocks, not filling email still yelds error:

    image

Copy link
Contributor

github-actions bot commented May 10, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/subscribe-button-only branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/subscribe-button-only
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Subscriptions [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels May 10, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for June 4, 2024 (scheduled code freeze on June 3, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@simison simison force-pushed the update/subscribe-button-only branch from e7c5997 to 7d723ea Compare May 10, 2024 12:39
@simison simison force-pushed the update/subscribe-button-only branch from 7d723ea to 31080c7 Compare May 17, 2024 09:12
@simison simison marked this pull request as ready for review May 17, 2024 11:54
@simison simison requested a review from a team May 17, 2024 11:54
"name": "split",
"label": "Split",
"isDefault": true
"name": "button",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could call it button-only, then we could do $is_style_button_only = get_attribute( $attributes, 'className' ) === 'is-style-button_only'; 🤓

@lezama
Copy link
Contributor

lezama commented May 17, 2024

Noticed that 'Subscribed' is centered

Screenshot 2024-05-17 at 9 25 34 AM

vs 'Subscribe'

Screenshot 2024-05-17 at 9 27 19 AM

@simison simison force-pushed the update/subscribe-button-only branch from 6124d2a to 042bf44 Compare May 17, 2024 12:30
@simison
Copy link
Member Author

simison commented May 17, 2024

Hmm yeah, that's from #37066

I could look into alignments in additional PR; I was thinking to add support for left/right alignment as well.

@simison simison force-pushed the update/subscribe-button-only branch from d50e3fb to 004f4e3 Compare May 20, 2024 08:43
@simison
Copy link
Member Author

simison commented May 20, 2024

Now just requires D148314-code merged first.

@pkuliga pkuliga merged commit 5669947 into trunk May 20, 2024
55 of 56 checks passed
@pkuliga pkuliga deleted the update/subscribe-button-only branch May 20, 2024 12:00
@github-actions github-actions bot added this to the jetpack/13.5 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriptions [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscribe block: button-only design
3 participants