Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A Client: Only show disconnect dialog during plugin deactivation when connected #37337

Merged
merged 2 commits into from
May 10, 2024

Conversation

nateweller
Copy link
Contributor

@nateweller nateweller commented May 9, 2024

Fixes https://github.com/Automattic/automattic-for-agencies-dev/issues/348

Proposed changes:

  • Checks if the site is connected before adding the deactivation handler that prompts to disconnect the site during plugin deactivation.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/automattic-for-agencies-dev/issues/348

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Spin up a JN site with the A4A client plugin installed.
  • With a disconnected site, deactivate the plugin. Verify no interstitial connection pop-up is shown and the plugin deactivates right away.
  • Re-activate the plugin, and connect the site.
  • Deactivate the plugin, verify the disconnect dialog pops up before deactivating the plugin.

Copy link
Contributor

github-actions bot commented May 9, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Automattic For agencies client plugin:

  • Next scheduled release: June 4, 2024.
  • Scheduled code freeze: May 27, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

@andrii-lysenko andrii-lysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me and works as described 👍

Copy link
Contributor

@gogdzl gogdzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nateweller nateweller merged commit 2d24fc4 into trunk May 10, 2024
56 checks passed
@nateweller nateweller deleted the fix/a4a/remove-disconnect-prompt-when-disconnected branch May 10, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants