-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Update list-repo-maintenance-commits #37329
Conversation
* Collect the stub updates separately, don't include them in the Renovate list. * Ignore `.phan/stubs/` and `tools/stubs/*-defs.php` when looking for PRs touching stuff outside of projects. Probably it's not really maintenance, just someone needing a new stub. * Allow for passing a date range into the script.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mechanism that switches the repo to trunk caught me, I thought the dates weren't working properly :) Good to go, looking good!
if [[ $1 =~ ^[0-9][0-9][0-9][0-9]-[0-9][0-9]-[0-9][0-9]$ ]]; then | ||
DS=$1 | ||
if [[ $2 =~ ^[0-9][0-9][0-9][0-9]-[0-9][0-9]-[0-9][0-9]$ ]]; then | ||
DE=$2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that technically this matches "dates" like 1924-90-90. I'd probably use date
to validate things.
Proposed changes:
.phan/stubs/
andtools/stubs/*-defs.php
when looking for PRs touching stuff outside of projects. Probably it's not really maintenance, just someone needing a new stub.Other information:
Jetpack product discussion
None
Does this pull request change what data or activity we track or use?
No
Testing instructions: