WordPress.com Block Editor Deprecate and move functionality to mu wpcom #37324

darssen · 2024-05-09T16:59:57Z

Proposed changes:

Deprecate WordPress.com Block Editor for self-hosted
Move the functionality to jetpack-mu-wpcom package
Fixed Unit Tests while moving them

Regarding deprecation notices and removal of the code, I took a different approach to #37260 or #37189 since the jetpack-mu-wpcom package is not available for the jetpack plugin.
The steps I take are as follows. After removing the loading of the file from the module-extras.php I decided to mark the file as deprecated as well as the init and the constructor. But leave the file as is since I cannot replace the functionality with the one in the mu-wpcom package due to being out of reach.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pfwV0U-9G-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Check in self-hosted and see that Justify and Underline formatting Tools are no longer available.
Make sure deprecation notices are not present unless the Class is declared explicitly.
Check that Simple and WoA still keep the justify and Underline formatting Tools

github-actions · 2024-05-09T17:00:47Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/move-wpcom-block-editor-to-jetpack-mu-wpcom branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/move-wpcom-block-editor-to-jetpack-mu-wpcom

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/move-wpcom-block-editor-to-jetpack-mu-wpcom

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2024-05-09T17:00:54Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen daily.
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for July 2, 2024 (scheduled code freeze on July 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Mu Wpcom plugin:

Next scheduled release: July 2, 2024.
Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

...ckages/jetpack-mu-wpcom/src/features/wpcom-block-editor/class-jetpack-wpcom-block-editor.php

…e-wpcom-block-editor-to-jetpack-mu-wpcom

...ckages/jetpack-mu-wpcom/src/features/wpcom-block-editor/class-jetpack-wpcom-block-editor.php

monsieur-z

All instructions tested as expected. Tested with self-hosted, simple and WoA sites.

fgiannar

While testing on a Simple site with Gutenframe (iframed block editor), I noticed the following warnings (not reproducible on trunk):

Warning: Undefined array key 1 in [REDACTED]/mu-plugins/jetpack-mu-wpcom-plugin/sun/vendor/automattic/jetpack-mu-wpcom/src/features/wpcom-block-editor/class-jetpack-wpcom-block-editor.php on line 256
Warning: Undefined array key 2 in [REDACTED]/mu-plugins/jetpack-mu-wpcom-plugin/sun/vendor/automattic/jetpack-mu-wpcom/src/features/wpcom-block-editor/class-jetpack-wpcom-block-editor.php on line 256

About Gutenframe: PCYsg-lwV-p2

…u-wpcom

…github.com:Automattic/jetpack into update/move-wpcom-block-editor-to-jetpack-mu-wpcom

fgiannar

Works as expected for self-hosted and Simple sites 👍

On WoA though, the Justify option is missing, plus getting the following error in the console:

…u-wpcom

coder-karen · 2024-06-05T08:06:39Z

...ckages/jetpack-mu-wpcom/src/features/wpcom-block-editor/class-jetpack-wpcom-block-editor.php

+
+		wp_localize_script(
+			'wpcom-block-editor-default-editor-script',
+			'jetpackMuWpcomGutenberg',


I wonder if we could change the variable back to wpcomGutenberg from jetpackMuWpcomGutenberg, but only on Atomic sites, as I know that it was changed because of a Simple issue: #37324 (comment)

Yeah, I noticed that too, trying to come with an idea that serves for the different environments.

…u-wpcom

coder-karen

Tests well for me on self-hosted, Atomic and Simple.

Issue has been addressed

anomiex · 2024-06-10T12:55:07Z

projects/packages/jetpack-mu-wpcom/.phan/baseline.php

@@ -53,6 +54,8 @@
        'src/features/marketplace-products-updater/class-marketplace-products-updater.php' => ['PhanTypeMismatchDimFetch', 'PhanTypeMismatchReturn'],
        'src/features/media/heif-support.php' => ['PhanPluginSimplifyExpressionBool'],
        'src/features/verbum-comments/class-verbum-comments.php' => ['PhanImpossibleTypeComparison', 'PhanNoopNew', 'PhanParamTooMany', 'PhanTypeMismatchArgumentProbablyReal', 'PhanUndeclaredFunction'],
+        'src/features/wpcom-block-editor/class-jetpack-wpcom-block-editor.php' => ['PhanUndeclaredFunctionInCallable'],


Probably shouldn't have ignored this. It was flagging a legitimate issue, see p1718019341602329-slack-C034JEXD1RD

@SInCE

…om (#37324) * Move code to package. Deprecate code in modules and not call it. * Fix bugs * Move tests to the mu-wpcom package * Update test * Phan updates for the mu-wpcom package * Phan updates for the jetpack plugin * Changelogger * Fix typos * Updated version * Fixed Unit Tests * Bump version mu-wpcom-plugin * Updated @SInCE references to indicate they come from jetpack * Updated comments related to Jetpack plugin * Autoload both files for wpcom block editor * Fixed typo * Updated function to set_cookie * Update phan baseline * Phan update * Version bump * Version bump * Marked functions file as deprecated in the module * Changed variable name for localize script * Remove isWoA check since it should work for simple as well * Remove wrong require that got added from merge * Added check for wpcom simple * Version bump * Added check for simple since same object is already localized there * Phan changes --------- Co-authored-by: Foteini Giannaropoulou <[email protected]>

darssen added 7 commits May 9, 2024 17:32

Move code to package. Deprecate code in modules and not call it.

1d106e5

Fix bugs

0d9b321

Move tests to the mu-wpcom package

967c571

Update test

b91a033

Phan updates for the mu-wpcom package

2053bea

Phan updates for the jetpack plugin

6dd37a9

Changelogger

e13425d

darssen added [Feature] WordPress.com Block Editor [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Package] Jetpack mu wpcom WordPress.com Features [Plugin] mu wpcom jetpack-mu-wpcom plugin [Focus] Jetstream labels May 9, 2024

darssen self-assigned this May 9, 2024

github-actions bot added [Status] In Progress [Tests] Includes Tests [mu wpcom Feature] WordPress.com Block Editor labels May 9, 2024

darssen commented May 9, 2024

View reviewed changes

...ckages/jetpack-mu-wpcom/src/features/wpcom-block-editor/class-jetpack-wpcom-block-editor.php Outdated Show resolved Hide resolved

darssen added 5 commits May 9, 2024 19:25

Fix typos

edc5d7a

Updated version

11a67ad

Fixed Unit Tests

fefcd38

Merge branch 'trunk' of github.com:Automattic/jetpack into update/mov…

8f4d3c7

…e-wpcom-block-editor-to-jetpack-mu-wpcom

Bump version mu-wpcom-plugin

47b0144

darssen marked this pull request as ready for review May 10, 2024 07:53

darssen requested a review from a team May 10, 2024 07:53

jeherve reviewed May 10, 2024

View reviewed changes

darssen added 3 commits May 10, 2024 12:07

Updated @SInCE references to indicate they come from jetpack

97f89df

Updated comments related to Jetpack plugin

c8427a6

Autoload both files for wpcom block editor

343fd38

monsieur-z previously approved these changes May 28, 2024

View reviewed changes

Remove wrong require that got added from merge

d31686c

darssen dismissed monsieur-z’s stale review via d31686c May 29, 2024 06:42

fgiannar requested changes May 29, 2024

View reviewed changes

bindlegirl added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jun 3, 2024

darssen and others added 4 commits June 4, 2024 13:13

Added check for wpcom simple

4bab43a

Version bump

d7cd5cc

Merge branch 'trunk' into update/move-wpcom-block-editor-to-jetpack-m…

d82d169

…u-wpcom

Merge branch 'update/move-wpcom-block-editor-to-jetpack-mu-wpcom' of …

6e1a558

…github.com:Automattic/jetpack into update/move-wpcom-block-editor-to-jetpack-mu-wpcom

fgiannar previously requested changes Jun 4, 2024

View reviewed changes

Merge branch 'trunk' into update/move-wpcom-block-editor-to-jetpack-m…

3eca904

…u-wpcom

coder-karen reviewed Jun 5, 2024

View reviewed changes

darssen added 4 commits June 7, 2024 12:11

Merge branch 'trunk' into update/move-wpcom-block-editor-to-jetpack-m…

dd506c3

…u-wpcom

Added check for simple since same object is already localized there

43fc592

Merge branch 'trunk' into update/move-wpcom-block-editor-to-jetpack-m…

ed87d0b

…u-wpcom

Phan changes

e19c59a

darssen requested a review from fgiannar June 7, 2024 12:26

darssen added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jun 7, 2024

Merge branch 'trunk' into update/move-wpcom-block-editor-to-jetpack-m…

6ab9d5b

…u-wpcom

coder-karen approved these changes Jun 10, 2024

View reviewed changes

darssen merged commit 40c1f14 into trunk Jun 10, 2024
56 checks passed

darssen deleted the update/move-wpcom-block-editor-to-jetpack-mu-wpcom branch June 10, 2024 11:07

github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jun 10, 2024

anomiex reviewed Jun 10, 2024

View reviewed changes

darssen mentioned this pull request Jun 10, 2024

Jetpack mu wpcom package: Fix typo in set cookie #37774

Merged

3 tasks

darssen mentioned this pull request Jul 11, 2024

WPCOM Block Editor: Removing files from the Jetpack plugin #38299

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WordPress.com Block Editor Deprecate and move functionality to mu wpcom #37324

WordPress.com Block Editor Deprecate and move functionality to mu wpcom #37324

darssen commented May 9, 2024 •

edited

Loading

github-actions bot commented May 9, 2024 •

edited

Loading

github-actions bot commented May 9, 2024 •

edited

Loading

monsieur-z left a comment

fgiannar left a comment •

edited

Loading

fgiannar left a comment

coder-karen Jun 5, 2024

darssen Jun 5, 2024

coder-karen left a comment

anomiex Jun 10, 2024

WordPress.com Block Editor Deprecate and move functionality to mu wpcom #37324

WordPress.com Block Editor Deprecate and move functionality to mu wpcom #37324

Conversation

darssen commented May 9, 2024 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented May 9, 2024 • edited Loading

github-actions bot commented May 9, 2024 • edited Loading

monsieur-z left a comment

Choose a reason for hiding this comment

fgiannar left a comment • edited Loading

Choose a reason for hiding this comment

fgiannar left a comment

Choose a reason for hiding this comment

coder-karen Jun 5, 2024

Choose a reason for hiding this comment

darssen Jun 5, 2024

Choose a reason for hiding this comment

coder-karen left a comment

Choose a reason for hiding this comment

anomiex Jun 10, 2024

Choose a reason for hiding this comment

darssen commented May 9, 2024 •

edited

Loading

github-actions bot commented May 9, 2024 •

edited

Loading

github-actions bot commented May 9, 2024 •

edited

Loading

fgiannar left a comment •

edited

Loading