Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup: Add a LoadingPlaceholder while waiting for Backup plan price #37238

Merged
merged 3 commits into from
May 7, 2024

Conversation

mavegaf
Copy link
Contributor

@mavegaf mavegaf commented May 6, 2024

Related to https://github.com/Automattic/jetpack-backup-team/issues/414

When you first render the VaultPress Backup pricing card, it says that costs is $0, and then it refreshes to $4.95.

Proposed changes:

  • Add a LoadingPlaceholder while is waiting for the price

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Install the branch add/loading-placeholder-while-waiting-price of Jetpack Backup in a site without backup
  • Check the plugin and verify a loading placeholder is shown before the final price

@mavegaf mavegaf added [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [JS Package] Components labels May 6, 2024
@mavegaf mavegaf self-assigned this May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Backup plugin:

  • Next scheduled release: June 4, 2024.
  • Scheduled code freeze: May 27, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented May 6, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/loading-placeholder-while-waiting-price branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/loading-placeholder-while-waiting-price
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/loading-placeholder-while-waiting-price
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@mavegaf mavegaf force-pushed the add/loading-placeholder-while-waiting-price branch from eef3a7d to 42a326a Compare May 6, 2024 21:25
@mavegaf mavegaf requested a review from Initsogar May 6, 2024 22:12
@mavegaf mavegaf marked this pull request as ready for review May 6, 2024 22:12
Copy link
Contributor

@Initsogar Initsogar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍🏽

CleanShot.2024-05-06.at.23.56.56.mp4

@mavegaf mavegaf merged commit 108b4ea into trunk May 7, 2024
74 checks passed
@mavegaf mavegaf deleted the add/loading-placeholder-while-waiting-price branch May 7, 2024 14:54
pkuliga pushed a commit that referenced this pull request May 9, 2024
…37238)

* Jetpack Backup: Add a LoadingPlaceholder while waiting for Jetpack backup prices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Components [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. RNA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants