Tiled Gallery: fix view rendering issues

[monsieur-z]

Fixes #37194

Proposed changes:

This PR fixes the Tiled Gallery not being rendered as expected in the frontend. The issues was introduced by #36854.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

• Don't checkout this branch just yet
• Spin up a test site
• Connect Jetpack
• Create a new post
• Add a Tiled Gallery block and select some images
• Checkout this branch
• Refresh the editor and verify there's no error message
• In the block styles panel, select Circles

• Open the preview
• Notice the items are circular

• Verify the other styles are rendered the same in the editor and frontend

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for June 4, 2024 (scheduled code freeze on May 27, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/tiled-gallery-view branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/tiled-gallery-view
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[coder-karen]

This works well in preview and for published pages.
However I notice in testing locally and with a Jurassic Ninja site that in the editor the images stay as squares. Checking back a few Jetpack versions I can see the new styles (circles) were previously showing in the editor as well as on the front-end.

[jeherve]

In the editor the images stay as squares.

Yes, that's what I'm seeing in my tests as well.

[monsieur-z]

The gallery was similar to the preview when I initially tested the PR, but testing again it's now different indeed! Not sure what I did there. Thanks for catching this.

[monsieur-z]

I've devised a new solution and updated the block save function to move the style-related class name one step higher. A new deprecated version was required for backward compatibility, so I've updated the instructions to take this into account.

[monsieur-z]

Ensure the gallery is rendered correctly in exising posts.

[coder-karen]

Works well for me!

Testing with a previously added gallery, there were no errors when updating the branch either.