Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Create a social service connect button #37196

Merged
merged 19 commits into from
May 13, 2024

Conversation

pablinos
Copy link
Contributor

@pablinos pablinos commented May 2, 2024

This is currently a proof of concept where we get the available external services and render a connect button, which in turn triggers the authentication flow for each service.

To test it, the site must be sandboxed with D146389-code applied.

Proposed changes:

  • Wire up connect buttons for the new connections management UI

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Goto Jetpack and Social admin pages
  • Click on Add new connection
  • Click on connect for any social network and complete the auth
  • Confirm that you see the appropriate data in console
  • Do the same for Mastodon
  • Confirm that you are take to the next step to enter username
  • Enter some wrong username
  • Confirm that you see a notice saying the username is invalid
  • Enter a valid username and complete the auth
  • Confirm that you see the connection data in console
  • Now connect Mastodon for the same site via Calypso
  • Come back to Social/Jetpack page and reload
  • Now try to connect the same Mastodon account
  • Confirm that you see the notice that the account is already connected
Screen.Recording.2024-05-09.at.6.38.48.PM.mov

Copy link
Contributor

github-actions bot commented May 2, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Social plugin:

  • Next scheduled release: June 4, 2024.
  • Scheduled code freeze: May 27, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented May 2, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/social-connect-button branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/social-connect-button
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/social-connect-button
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@@ -266,6 +268,20 @@ public function initial_state() {
return $state;
}

public function get_services() {
$site_id = Connection_Manager::get_site_id();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API call should probably be cached, so we're not making another API request on each load of the admin page, especially as this data will not change very often

This is currently a proof of concept where we get the available external
services and render a connect button, which in turn triggers the
authentication flow for each service.

To test it, the site must be sandboxed with D146389-code applied.
@pablinos pablinos force-pushed the add/social-connect-button branch from 81e44f8 to b8d5b9b Compare May 8, 2024 22:13
@manzoorwanijk manzoorwanijk self-assigned this May 9, 2024
@manzoorwanijk manzoorwanijk marked this pull request as ready for review May 9, 2024 13:12
@manzoorwanijk manzoorwanijk requested a review from a team May 9, 2024 13:12
Copy link
Contributor Author

@pablinos pablinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well for me apart from the problem we're discussing with Tumblr. Just a comment about the available services

manzoorwanijk
manzoorwanijk previously approved these changes May 13, 2024
@spsiddarthan
Copy link
Contributor

It says WPCOM tests are failing, maybe that's ok? Also, should we do a sanity check on WPCOM as well with this patch and make sure the editor loads?

@manzoorwanijk manzoorwanijk merged commit 839954e into trunk May 13, 2024
72 checks passed
@manzoorwanijk manzoorwanijk deleted the add/social-connect-button branch May 13, 2024 05:50
@manzoorwanijk manzoorwanijk restored the add/social-connect-button branch May 13, 2024 05:52
@manzoorwanijk manzoorwanijk deleted the add/social-connect-button branch May 13, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants