SSO: switch from module codebase to Connection package, part 3 #37153

jeherve · 2024-05-01T09:53:26Z

Fixes https://github.com/Automattic/vulcan/issues/274
Fixes https://github.com/Automattic/vulcan/issues/254

Proposed changes:

This PR is the final part of moving the SSO feature codebase to the Connection package.

It follows the work done in #36587, #36924, and #36989.

We switch to loading the feature from the connection package in all parts of the Jetpack plugin codebase.
We deprecate all module codebase classes and methods

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/vulcan/issues/251

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Go to Jetpack > Settings > Security and enable the SSO feature.
Log out and log back in, with your main user and with new users.
Check your error logs and ensure that no deprecation notices appear in the logs.
Check that there are no errors in CI.

github-actions · 2024-05-01T09:54:16Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/sso-use-package branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/sso-use-package

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/sso-use-package

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2024-05-01T09:54:39Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen daily.
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for June 4, 2024 (scheduled code freeze on June 3, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

projects/plugins/jetpack/class.jetpack.php

projects/plugins/jetpack/modules/sso.php

See https://github.com/Automattic/jetpack/pull/37153/files#r1586113523

projects/plugins/jetpack/json-endpoints/jetpack/class.jetpack-json-api-user-create-endpoint.php

projects/plugins/jetpack/modules/sso.php

projects/plugins/jetpack/modules/sso/class-jetpack-force-2fa.php

projects/plugins/jetpack/modules/sso/class.jetpack-sso-user-admin.php

projects/plugins/jetpack/tests/php/modules/sso/test_class.jetpack-sso-helpers.php

Co-authored-by: sergeymitr <[email protected]>

* SSO: remove references to Jetpack class * Switch to modern display of notice and add missing i18n wrapping * Load SSO feature from the Connection package * Switch to Connection package for all SSO references * Deprecate all module classes and methods * Remove module test * Remove test reference too * Remove one more test directory (multisite) * Update Phan config * Move SSO callables to the Connection package See https://github.com/Automattic/jetpack/pull/37153/files#r1586113523 * Add deprecated class back Co-authored-by: sergeymitr <[email protected]> * Remove deprecated private methods See https://github.com/Automattic/jetpack/pull/37153/files#r1586438953 Co-authored-by: sergeymitr <[email protected]> * Remove private properties and methods See Automattic/jetpack#37153 (comment) Co-authored-by: sergeymitr <[email protected]> * Move user generation to Utils class See Automattic/jetpack#37153 (comment) * Try fixing tests * Revert "Try fixing tests" This reverts commit 0ea30ae53034e025fa3e7938470991b65d254204. * Bump versions * Ensure the SSO module is used in tests * Add new SSO XML-RPC method * Jetpack Connection: Bump package version --------- Co-authored-by: sergeymitr <[email protected]> Co-authored-by: Foteini Giannaropoulou <[email protected]> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/9080205827 Upstream-Ref: Automattic/jetpack@101ddb3

Fixes Automattic/vulcan#385 This codebase was deprecated in #37153, it's now time to remove it.

…39327) * SSO: remove legacy codebase in favor of code in Connection package Fixes Automattic/vulcan#385 This codebase was deprecated in #37153, it's now time to remove it. * Remove admin CSS building tooling

jeherve added 6 commits May 1, 2024 11:44

SSO: remove references to Jetpack class

51be1c0

Switch to modern display of notice and add missing i18n wrapping

83a29ad

Load SSO feature from the Connection package

7054189

Switch to Connection package for all SSO references

3b7fafa

Deprecate all module classes and methods

feb2bb4

Remove module test

914d1d3

jeherve added [Feature] SSO [Status] In Progress [Type] Janitorial [Pri] Normal labels May 1, 2024

jeherve self-assigned this May 1, 2024

github-actions bot added [Feature] WPCOM API [Package] Connection [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests labels May 1, 2024

jeherve commented May 1, 2024

View reviewed changes

projects/plugins/jetpack/class.jetpack.php Outdated Show resolved Hide resolved

jeherve commented May 1, 2024

View reviewed changes

projects/plugins/jetpack/modules/sso.php Show resolved Hide resolved

jeherve requested a review from a team May 1, 2024 09:59

jeherve added 3 commits May 1, 2024 12:00

Remove test reference too

b544238

Remove one more test directory (multisite)

18dbc04

Update Phan config

c17a41e

jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Team Review and removed [Status] In Progress labels May 1, 2024

jeherve mentioned this pull request May 1, 2024

SSO: Log error message from user invite response #37144

Merged

3 tasks

Move SSO callables to the Connection package

d05c401

See https://github.com/Automattic/jetpack/pull/37153/files#r1586113523

sergeymitr reviewed May 1, 2024

View reviewed changes

Add deprecated class back

c2294ed

Co-authored-by: sergeymitr <[email protected]>

jeherve added [Status] Needs Testing We need to add this change to the testing call for this month's release labels May 14, 2024

jeherve mentioned this pull request Jul 3, 2024

WooCommerce Auth: move away from deprecated Jetpack_SSO class woocommerce/woocommerce#49100

Closed

5 tasks

jeherve added a commit that referenced this pull request Sep 10, 2024

SSO: remove legacy codebase in favor of code in Connection package

1f1cb5d

Fixes Automattic/vulcan#385 This codebase was deprecated in #37153, it's now time to remove it.

jeherve mentioned this pull request Sep 10, 2024

SSO: remove legacy codebase in favor of code in Connection package #39327

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SSO: switch from module codebase to Connection package, part 3 #37153

SSO: switch from module codebase to Connection package, part 3 #37153

jeherve commented May 1, 2024

github-actions bot commented May 1, 2024 •

edited

Loading

github-actions bot commented May 1, 2024 •

edited

Loading

SSO: switch from module codebase to Connection package, part 3 #37153

SSO: switch from module codebase to Connection package, part 3 #37153

Conversation

jeherve commented May 1, 2024

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented May 1, 2024 • edited Loading

github-actions bot commented May 1, 2024 • edited Loading

github-actions bot commented May 1, 2024 •

edited

Loading

github-actions bot commented May 1, 2024 •

edited

Loading