Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Social Logos to monorepo #36964

Merged
merged 239 commits into from
May 23, 2024
Merged

Add Social Logos to monorepo #36964

merged 239 commits into from
May 23, 2024

Conversation

tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Apr 17, 2024 •
edited
Loading

Moves Social Logos package into the monorepo

Proposed changes:

This PR moves the Social Logos package into the monorepo. Originally I was going to wait for some feedback on a related project, but figured it's best to just wrap this up and iterate as needed.

Related tasks:

  • Rewrite/clean up readme and any other such files
  • Audit existing issues in the original repo
  • Finish configuring the mirror repo
  • Confirm what exactly needs to be committed to the repo and NPM. For example, historically we've only provided .js files to NPM, and this now only has the .jsx files; I'm not sure if that will be a problem or not. If we need to transpile prior to publishing, maybe this is what I need to understand.
  • Do an official release of the package (v3.0)
  • Maybe make a composer package for the PHP files?

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Run jetpack build js-packages/social-logos and verify the build folder is generated.
  2. Add an SVG to /src/svg.
  3. Run ./tools/build
  4. Verify the generated files match what one would expect.

davewhitley and others added 30 commits September 17, 2015 13:27
@davewhitley
Initial commit
614b4c7
@davewhitley
Updating the readme with some basic text
5a42f98
@davewhitley
Updating readme
e6dcfa7
@davewhitley
Adding initial files
ba90f47 
- Illustrator document
- SVGs
- exporter script
@davewhitley
Updating readme
7ed62bb
@davewhitley
Update README.md
d0e2655
@davewhitley
Update README.md
6e4ab00
@davewhitley
Update README.md
51efedf
@davewhitley
Updates
f0e8416 
- Fixing typos
- Adding more resources
@davewhitley
Adding one more resource
fb0e1ac
@davewhitley
Renaming file
1717f92
@davewhitley
Updating google plus logos
f62919b
@davewhitley
Fixing error with svg
9f41e89
@davewhitley
Update README.md
7628204
@davewhitley
Adding reddit brand page
f02ac00
@davewhitley
Adding reddit logo
94d68b6
@enejb
Adds Grunt Build Script
3b0a098 
This makes it work in the simular way that the current gridicon grunt buil script works.
@jasmussen
Add a number of fixes to the grunt process
fe5ad12 
- Fix typo in package.json
- Remove invisible rectangle from Illustrator file, this is auto inserted by the grunt script and breaks other things if present
- Add circle around alternate G+ logo to adhere with guidelines
- Properly compound Path, Tumblr and a few other icons that actually featured white fills instead of negative space
@enejb
Added Icon font build scripts
d9b7b93
@enejb
Add png files build script
0534e47
@jasmussen
Add all the missing logos from Genericons
9cc3b47 
Also grunt it.
@enejb
Merge pull request #4 from Automattic/add/grunt-buildscript
30e693a 
Adds Grunt Build Script
@enejb
Remove PNG files and the build script part that creats them from repo
e1a7ba0
@enejb
Merge pull request #7 from Automattic/remove/png-from-build-script
04a981f 
Remove PNG files and the build script part that are creates them.
@enejb
Remove PHP function that displays the icons in the svg format
c9e61ab
@enejb
Merge pull request #6 from Automattic/remove/php-from-build-script
bad2a12 
Remove PHP function that displays the icons in the svg format
@jasmussen
Add WhatsApp, Telegram, mail, update print
dcf35d3 
Also grunt the lot.
@jasmussen
Merge pull request #8 from Automattic/polish/icons
750c9b5 
Add WhatsApp, Telegram, mail, update print
@jasmussen
Grunt: Fix typo in sprite build script.
4c8ed6f 
The closing head tag wasn't closing.
@enejb
Add codepoints to match the current grenericons
1dab3a3
anomiex
anomiex previously approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it.

@tbradsha tbradsha merged commit abe33ba into trunk May 23, 2024
71 of 72 checks passed
@tbradsha tbradsha deleted the add/social_logos_to_monorepo branch May 23, 2024 15:19
@tbradsha tbradsha removed the DO NOT MERGE don't merge it! label May 23, 2024
@github-actions github-actions bot added this to the jetpack/13.5 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomiex anomiex anomiex approved these changes

Assignees

@tbradsha tbradsha

Labels
Actions GitHub actions used to automate some of the work around releases and repository management Docs [JS Package] Components [JS Package] Social Logos [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA
Projects
None yet
Milestone
jetpack/13.5
Development

Successfully merging this pull request may close these issues.