Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: ensure playsInline attribute conforms when falling back to core Video block #36030

Merged
merged 3 commits into from
Feb 29, 2024
Merged

revert: ensure playsInline attribute conforms when falling back to core Video block #36030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d1f9c4
fix: Revert change to playsInline attribute
Feb 28, 2024
d6042bc
docs: Add CHANGELOG
Feb 28, 2024
2426a82
Merge branch 'trunk' into rnmobile/revert-playsinline-setting-change-…
Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/rnmobile-revert-playsinline-setting-change-in-core-video
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

RNMobile: Revert change to the way playsInline attribute is saved, prevent regression on web.
9 changes: 1 addition & 8 deletions projects/plugins/jetpack/extensions/blocks/videopress/save.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,7 @@ const VideoPressSave = CoreVideoSave => props => {
* @see https://github.com/WordPress/gutenberg/blob/c5f9bd88125282a0c35f887cc8d835f065893112/packages/editor/src/hooks/generated-class-name.js#L42
* @see https://github.com/Automattic/wp-calypso/pull/30546#issuecomment-463637946
*/
// Rename `playsinline` to `playsInline` to conform the block schema of core Video block.
const { playsinline: videoPressPlayinline, ...restAttributes } = props.attributes;
const coreVideoAttributes = { ...restAttributes, playsInline: playsinline };

return CoreVideoSave( {
...props,
attributes: coreVideoAttributes,
} );
return CoreVideoSave( props );
}

const url = getVideoPressUrl( guid, {
Expand Down
Loading