Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription Block: Add newsletter categories to the content view #32756

Merged
merged 9 commits into from
Sep 11, 2023
Merged

Subscription Block: Add newsletter categories to the content view #32756

merged 9 commits into from
Sep 11, 2023

Conversation

phcp
Copy link
Contributor

@phcp phcp commented Aug 29, 2023 •
edited
Loading

Closes Automattic/wp-calypso#80905
Depends on #32666

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pdDOJh-2jl-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Apply this PR to your local env
  2. Spin up a Jurassic Tube site with this PR
  3. Test with a site that has Newsletter Categories already defined
  4. Add the Subscribe block to a post/page
  5. Open the post/page and see if the categories are displayed

@phcp phcp self-assigned this Aug 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the add/newsletter-categories-content-view branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/newsletter-categories-content-view

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Subscriptions [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Aug 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

  • Next scheduled release: October 3, 2023.
  • Scheduled code freeze: September 25, 2023.

@jeherve jeherve added the [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. label Aug 30, 2023
@TimBroddin
Copy link
Contributor

I updated this PR to make the pills interactive & to pass the (unselected) values to the iframe. I'm still testing it.

CleanShot.2023-09-07.at.14.51.15.mp4

I'm not too sure about the transition, it makes it feel slower than it is. I'll probably remove it.

@TimBroddin TimBroddin assigned TimBroddin and unassigned phcp Sep 7, 2023
@TimBroddin TimBroddin requested a review from a team September 7, 2023 14:54
@phcp
Copy link
Contributor Author

phcp commented Sep 7, 2023

@TimBroddin I tested on both scenarios and it looks good. I can't approve as I started the PR, but feel free to move forward (:

TimBroddin
TimBroddin approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@TimBroddin TimBroddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phcp approves it, but can't approve it because he's the original author of this co-effort. I'll approve in his place.

@TimBroddin TimBroddin marked this pull request as ready for review September 11, 2023 07:06
@TimBroddin
Copy link
Contributor

Closes #80906

@TimBroddin TimBroddin added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Sep 11, 2023
@jeherve jeherve requested a review from a team September 11, 2023 10:21
@jeherve
Copy link
Member

jeherve commented Sep 11, 2023

@Automattic/zap Would you like to take a look at this? I think it may be something of interest for your team!

jeherve
jeherve approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@jeherve jeherve added [Status] Needs Team Review and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 11, 2023
@simison
Copy link
Member

simison commented Sep 11, 2023

@jeherve thanks for the ping — yep we've been following along and originally designed the functionality. :-)

@TimBroddin TimBroddin force-pushed the add/newsletter-categories-content-view branch from 0a9df4e to 1705bfb Compare September 11, 2023 13:15
@TimBroddin TimBroddin merged commit 6671012 into trunk Sep 11, 2023
53 checks passed
@TimBroddin TimBroddin deleted the add/newsletter-categories-content-view branch September 11, 2023 14:45
@github-actions github-actions bot added this to the jetpack/12.5.1 milestone Sep 11, 2023
mikestottuk pushed a commit that referenced this pull request Sep 18, 2023
@phcp @TimBroddin
[not verified] Subscription Block: Add newsletter categories to the c…
fecb3a7 
…ontent view (#32756)

* [not verified] Add newsletter categories to the subscription block content view

* [not verified] changelog

* [not verified] Include additional checks to ensure response types

* [not verified] Set border radius css variable

* [not verified] Fix lint

* [not verified] Make the pills interactive

* [not verified] Fallback to white & make transition faster

* [not verified] Add ticks & follow design

* [not verified] Merge with trunk & lose the extra div

---------

Co-authored-by: Tim Broddin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimBroddin TimBroddin TimBroddin approved these changes

@jeherve jeherve jeherve approved these changes

Assignees

@TimBroddin TimBroddin

Labels
[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project [Block] Subscriptions [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Package] Blocks [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Milestone
jetpack/12.5.1
Development

Successfully merging this pull request may close these issues.

Newsletter Categories: Render non-interactive newsletter category pills in the published content
4 participants
@phcp @TimBroddin @jeherve @simison