-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump default node version to 18.17.0 to match Calypso #32719
Conversation
Updating `.nvmrc` and `version.sh`. Leaving the engines in `package.json` at 18.13.0 as we're not planning on using any of the thing added in versions in between.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
…32719) Updating `.nvmrc` and `version.sh`. Leaving the engines in `package.json` at 18.13.0 as we're not planning on using any of the thing added in versions in between.
…32719) Updating `.nvmrc` and `version.sh`. Leaving the engines in `package.json` at 18.13.0 as we're not planning on using any of the thing added in versions in between.
Proposed changes:
Updating
.nvmrc
andversion.sh
. Leaving the engines inpackage.json
at 18.13.0 as we're not planning on using any of the thing added in versions in between.Other information:
Jetpack product discussion
p4TIVU-aKr-p2
Announcement for when this is merged: pdWQjU-tK-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
nvm use
gets the right version.jetpack
andtools/check-development-environment.sh
if you have a lower version of node 18 installed.