Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default node version to 18.17.0 to match Calypso #32719

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Aug 28, 2023

Proposed changes:

Updating .nvmrc and version.sh. Leaving the engines in package.json at 18.13.0 as we're not planning on using any of the thing added in versions in between.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p4TIVU-aKr-p2
Announcement for when this is merged: pdWQjU-tK-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Check that stuff works.
    • If you use nvm, see that nvm use gets the right version.
    • You might also check the output from jetpack and tools/check-development-environment.sh if you have a lower version of node 18 installed.

Updating `.nvmrc` and `version.sh`. Leaving the engines in
`package.json` at 18.13.0 as we're not planning on using any of the
thing added in versions in between.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Aug 28, 2023
@anomiex anomiex self-assigned this Aug 28, 2023
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the update/node-version branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/node-version
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/node-version
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! [Tools] Monorepo Setup and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 29, 2023
@anomiex anomiex merged commit a63a38b into trunk Aug 29, 2023
62 of 63 checks passed
@anomiex anomiex deleted the update/node-version branch August 29, 2023 13:11
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 29, 2023
TimBroddin pushed a commit that referenced this pull request Aug 29, 2023
…32719)

Updating `.nvmrc` and `version.sh`. Leaving the engines in
`package.json` at 18.13.0 as we're not planning on using any of the
thing added in versions in between.
TimBroddin pushed a commit that referenced this pull request Sep 5, 2023
…32719)

Updating `.nvmrc` and `version.sh`. Leaving the engines in
`package.json` at 18.13.0 as we're not planning on using any of the
thing added in versions in between.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants