Skip to content

Commit

Permalink
revert: ensure playsInline attribute conforms when falling back to …
Browse files Browse the repository at this point in the history
…core Video block (#36030)

* fix: Revert change to playsInline attribute

* docs: Add CHANGELOG
  • Loading branch information
Siobhan Bamber authored Feb 29, 2024
1 parent 26e4417 commit f3ebcf3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

RNMobile: Revert change to the way playsInline attribute is saved, prevent regression on web.
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,7 @@ const VideoPressSave = CoreVideoSave => props => {
* @see https://github.com/WordPress/gutenberg/blob/c5f9bd88125282a0c35f887cc8d835f065893112/packages/editor/src/hooks/generated-class-name.js#L42
* @see https://github.com/Automattic/wp-calypso/pull/30546#issuecomment-463637946
*/
// Rename `playsinline` to `playsInline` to conform the block schema of core Video block.
const { playsinline: videoPressPlayinline, ...restAttributes } = props.attributes;
const coreVideoAttributes = { ...restAttributes, playsInline: playsinline };

return CoreVideoSave( {
...props,
attributes: coreVideoAttributes,
} );
return CoreVideoSave( props );
}

const url = getVideoPressUrl( guid, {
Expand Down

0 comments on commit f3ebcf3

Please sign in to comment.