Carousel: Check we can preload an image before attempting it (#40535)

* Check if the gallery src is set before using it * changelog
Automattic · Dec 10, 2024 · c4ce87e · c4ce87e
1 parent 3f6eae4
commit c4ce87e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/projects/plugins/jetpack/changelog/fix-carousel-null-request b/projects/plugins/jetpack/changelog/fix-carousel-null-request
@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+Carousel: Under rare circumstances, the carousel will make null requests when loading an image
diff --git a/projects/plugins/jetpack/modules/carousel/jetpack-carousel.js b/projects/plugins/jetpack/modules/carousel/jetpack-carousel.js
@@ -1320,7 +1320,7 @@
 			var max = calculateMaxSlideDimensions();
 
 			// If the startIndex is not 0 then preload the clicked image first.
-			if ( startIndex !== 0 ) {
+			if ( startIndex !== 0 && items[ startIndex ].getAttribute( 'data-gallery-src' ) !== null ) {
 				var img = new Image();
 				img.src = items[ startIndex ].getAttribute( 'data-gallery-src' );
 			}