Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using a different harper-ls executable than the one bundled in the VSCode extension #330

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

mcecode
Copy link
Contributor

@mcecode mcecode commented Dec 24, 2024

Closes #321

I didn't add a test for the new setting since it'd be hard to distinguish if the extension is actually using a different binary or if it's just ignoring the setting and is using what's bundled because output wise, changing to a different executable should yield the same diagnostics in the editor.

@elijah-potter
Copy link
Collaborator

Looks great to me! Merging...

As an aside: we're setting up more extensive documentation on the website. Once that's done, we'll want future documentation to be put in there.

Initial drafts of the VSCode page are here.

@elijah-potter elijah-potter merged commit 1cd29ac into Automattic:master Dec 26, 2024
17 checks passed
@mcecode mcecode deleted the vscode-executable-path branch December 28, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode extension not starting on nixos
2 participants