Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove raw hashes that are unnecessary #324

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hamirmahal
Copy link

Closes #323

Copy link
Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo test passes locally.

@hamirmahal
Copy link
Author

I came across this repository when looking for alternatives to Grammarly. Thanks for making this open source.

Copy link
Contributor

@grantlemons grantlemons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't personally feel this is important. I kinda like the consistency of using raw strings even if they may not be needed.

I also think this standard is hard to maintain. If there was a clippy lint that would help us be consistent, I would be much more on board with it.

Also, this will need to be expanded to open PRs as well, so if this gets merged we'll need to look at all the open PRs to make appropriate changes.

Would love more discussion here, as I don't think there is a clear answer.

@hamirmahal
Copy link
Author

Oh, there's a Clippy lint for it, clippy::needless_raw_string_hashes.

@elijah-potter
Copy link
Collaborator

I'm with @grantlemons on this. I appreciate your effort on this, but this PR as it stands right now is pedantic and doesn't really address the underlying problem. That said, if you were able to configure our build system (which runs cargo check) to catch the problem, I would merge it.

@hamirmahal
Copy link
Author

I've been looking into this. We can modify justfile to catch this issue outside of tests.

If we want to catch the issue when it appears inside of tests, too, I think we'd need to do cargo clippy --all-targets in justfile, which had a lot of output when I ran it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are some unnecessary #s
3 participants