-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove raw hashes that are unnecessary #324
base: master
Are you sure you want to change the base?
refactor: remove raw hashes that are unnecessary #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo test
passes locally.
I came across this repository when looking for alternatives to Grammarly. Thanks for making this open source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't personally feel this is important. I kinda like the consistency of using raw strings even if they may not be needed.
I also think this standard is hard to maintain. If there was a clippy lint that would help us be consistent, I would be much more on board with it.
Also, this will need to be expanded to open PRs as well, so if this gets merged we'll need to look at all the open PRs to make appropriate changes.
Would love more discussion here, as I don't think there is a clear answer.
Oh, there's a Clippy lint for it, |
I'm with @grantlemons on this. I appreciate your effort on this, but this PR as it stands right now is pedantic and doesn't really address the underlying problem. That said, if you were able to configure our build system (which runs |
I've been looking into this. We can modify If we want to catch the issue when it appears inside of tests, too, I think we'd need to do |
Closes #323