Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove array class arguments #2828

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Remove array class arguments #2828

merged 1 commit into from
Jun 18, 2024

Conversation

gikaragia
Copy link
Contributor

@gikaragia gikaragia commented Jun 14, 2024 •
edited by github-actions bot
Loading

Changes Proposed in this Pull Request

Testing Instructions

  • Add the job_manager_ui_test shortcode in a page
  • Visit the page and observe that no warnings are raised.
Plugin build for 84468f6
📦 Download plugin zip
▶️ Open in playground

@gikaragia gikaragia self-assigned this Jun 14, 2024
fjorgemota
fjorgemota approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@fjorgemota fjorgemota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gikaragia gikaragia merged commit ea40602 into trunk Jun 18, 2024
12 checks passed
@gikaragia gikaragia deleted the fix/string-conversion-warnings branch June 18, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjorgemota fjorgemota fjorgemota approved these changes

Assignees

@gikaragia gikaragia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gikaragia @fjorgemota