Change TagsStream and SharedHierarchyStream primary_keys #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To comply with [singer specifications](https://github.com/singer-io/getting-started/blob/master/docs/SPEC.md#schema-message) key_properties needs to exist on top level (or be an empty list), of which Tags and Shared does not have ["id"].
|
Great fix I caught this myself as well on #42 , this will close that! Thank you! |
|
The test failed due to #14 , I"ll have to fix that at some point but I"m confident with this so I"ll merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To comply with singer specifications key_properties needs to exist on top level (or be an empty list), of which Tags and Shared does not have ["id"].
To fix I found that changing the Tags primary key to be indexed by ["name"] would populate with all of the tags used.
For shared hierarchy, I set the primary index to be a null list because Its going to cause inconsistency, if being recorded at this time, as theres no ["id"] attributed to itself. Although, to add them its going to need to get_children and recursively add its shared tasks, lists, and folders