forked from Compass/compass-rails
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update #1
Open
pelcasandra
wants to merge
61
commits into
Audify:master
Choose a base branch
from
Compass:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow up to sass-rails 5.0.x
This package has changed from 'compass-sasy-plugin' to just 'susy'.
…Sprockets::SassTemplate so calling .parent::SassImporter fails. Switched to always using Sprockets::SassImporter
…h is run on a class in Haml::Filters and so SassImporter may not be available in the same module.
…sass-rails-change sass-rails changed Sass::Rails::SassTemplate so it no longer extends Spr...
Updates the package name for sasy in README
remove compass-blueprint from all gemfiles
Based on #236, I’m bumping the version to 3.0.0
#trail no longer exists, and the functionality in Sprockets 3 now exists in the Sprockets::Environment class (and its cached sibling).
#trail is a protected method.
This should allow Sprockets 2 to be installed for Rails 3
This commit changes the root of the file cache to match the default in sprockets-rails and write to the app-level tmp folder. This also has the added benefit of segregating asset caches by environment.
Reflects the cache directory fix.
Sprockets 3 support
Updated Appraisals, Travis CI to confirm gem works in Rails 5
undefined method `=~' for #<Pathname:../images/icons/facebook.png>
Rails 4.2 should be tested against sprockets 3.x.
Fixed testing regression in 6dc0a83.
Fix assets:precompile in Production mode when using Sprockets 3.
when using sprockets 3.
Fixed TypeError: no implicit conversion of Sprockets::Asset into String
Because the raster PNGs make eyes bleed on retina displays 😎 [skip ci]
Switch to SVG badges in README
Readme changes : Added rails 5 compatibility infos
fix error due to Sprockets 4 no longer handling pathnames
This might be a fake filename, eg by NOT IMPORTED prefix by compass-import-once.
Only add dependency if file really exist.
Compass' merged PR Compass/compass#2094 is a clear indication that compass is no longer supported.
It used to have the constraints ">= 5.0.0.alpha" and "< 5.1", but the version "5.1.0.rc2" is technically considered to be < "5.1.0", so bundler failed to pick up the right Rails version. This commit updates the Appraisals file to be more precise in terms of version constraints.
Do not test against combinations of too new Rubies and old Rails
Update Appraisals to really point to Rails 5.0
Test against Rails 5.1 and edge
Update README to advise people not to start new projects with compass
I've maintained CI configuration, because my legacy project depends on this gem. And we need to safely merge No.279 pull request. It seems that framework versions is too old in travis config. So I've updated them. Support Rails versions: - 4.2 - 5.0 - 5.1 - 5.2 - 6.0 - 6.1 (edge) Drop Rails versions (these are not maintained by rails): - 3.1 - 3.2 - 4.0 - 4.1 In addition, I also have updated Ruby version in travis config: - 2.4.9 - 2.5.7 - 2.6.5 - 2.7.0 Currently, Ruby 2.3 or ealier series are not supported. So I've dropped them.
According to Rails Guide, it seems that v4.2 and 5.0 and 5.1 have also already been unsupported versions. So I'm going to drop them in CI config. See at: https://guides.rubyonrails.org/maintenance_policy.html#security-issues
Support Rails 6.0, and drop 3.x, 4.x, 5.0 and 5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.