Moved custom module to a later position to override Publish-GithubRel… #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ease function
The builds fail due to a conflict of two modules have same function with different parameters. This PR is a simple attempt to change the default build script behavior.
Description
The BuildTools.psm1 module of yours is defined in the build script.
ConfluencePS/ConfluencePS.build.ps1
Line 31 in c86f787
Then BuildHelpers module is imported 3 lines later.
ConfluencePS/ConfluencePS.build.ps1
Line 34 in c86f787
However they both have the same command,
Publish-GithubRelease
with different parameters. The first one, your custom module requires a parameter calledGITHUB_ACCESS_TOKEN
while the latter requiresAccessToken
as you can see here. And the second one is imported later with-Force
parameter, it overrides the function from the first module. It is better to make a decision:Publish-GithubRelease
from BuildTools.psm1 and use the one from BuildHelpers module.This PR picks the first option.
NB! I did not have the means to test your pipeline so the change also can create newer conflicts.
Motivation and Context
closes (#200)
Types of changes
Checklist