Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved custom module to a later position to override Publish-GithubRel… #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zbalkan
Copy link

@zbalkan zbalkan commented Mar 28, 2022

…ease function

The builds fail due to a conflict of two modules have same function with different parameters. This PR is a simple attempt to change the default build script behavior.

Description

The BuildTools.psm1 module of yours is defined in the build script.

Import-Module "$PSScriptRoot/Tools/BuildTools.psm1" -Force -ErrorAction Stop

Then BuildHelpers module is imported 3 lines later.

Import-Module BuildHelpers -Force -ErrorAction Stop

However they both have the same command, Publish-GithubRelease with different parameters. The first one, your custom module requires a parameter called GITHUB_ACCESS_TOKEN while the latter requires AccessToken as you can see here. And the second one is imported later with -Force parameter, it overrides the function from the first module. It is better to make a decision:

  • Keep both functions but move custom module a few lines below to override external one.
  • Remove Publish-GithubRelease from BuildTools.psm1 and use the one from BuildHelpers module.

This PR picks the first option.

NB! I did not have the means to test your pipeline so the change also can create newer conflicts.

Motivation and Context

closes (#200)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant