Skip to content

Commit

Permalink
gas: fix a testcase broken by new ZSTD support
Browse files Browse the repository at this point in the history
The commit 1369522 ("Recognize the new ELF
compression type for ZSTD.") added the new ELF compression type but it
accidentally broke a GAS testcase.  Since testing for the section type
"2048" (SHF_COMPRESSED) is not going to be portable in the long term, it
now tests SHF_LINK_ORDER ("128") instead.

Using SHF_LINK_ORDER (with possibly sh_link == 0) is an idea by Jan Beulich.

gas/ChangeLog:

	* testsuite/gas/elf/section10.s: Use SHF_LINK_ORDER to test
	mixed numeric and alpha values.
	* testsuite/gas/elf/section10.d: Reflect the change above.
  • Loading branch information
a4lg authored and jbeulich committed Aug 5, 2022
1 parent 5858ac6 commit 8005415
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions gas/testsuite/gas/elf/section10.d
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
[ ]*\[.*6000000\]: OS \(.*6000000\)
[ ]*\[.*\][ ]+sec2
[ ]*PROGBITS.*
[ ]*\[0+00806\]: ALLOC, EXEC, COMPRESSED
[ ]*\[<unknown>: 0x[0-9]+\], .*
[ ]*\[0+00086\]: ALLOC, EXEC, LINK ORDER
#...
[ ]*\[.*\][ ]+sec3
[ ]*PROGBITS.*
Expand Down
2 changes: 1 addition & 1 deletion gas/testsuite/gas/elf/section10.s
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
.word 1

# Make sure that a numeric value can be mixed with alpha values.
.section sec2, "a2048x"
.section sec2, "a128x"
.word 2

# Make sure that specifying further arguments to .sections is still supported
Expand Down

0 comments on commit 8005415

Please sign in to comment.