Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Containers] Update Swift examples. #126

Merged
merged 4 commits into from
Apr 11, 2017

Conversation

sunshinejr
Copy link
Contributor

Hey! This time I've tried to update all containers in one PR, but unfortunately I did not manage to (see #125). So with that PR merged we would only have to check if ASNodeController is fine I guess.

One thing that I don't know if it should be in this PR is changing the spacing style in the ASCollectionNode page, e.g. from:

flowLayout.minimumInteritemSpacing  = 1
flowLayout.minimumLineSpacing       = 1

to:

flowLayout.minimumInteritemSpacing = 1
flowLayout.minimumLineSpacing = 1

I didn't see much of that style around the docs so I though that it is kinda inconsistent and updated it as well. Let me know if I should fix anything here :)

Cheers! 🎉

@appleguy
Copy link
Contributor

@sunshinejr thanks again for the contributions — deeply appreciated! Feel free to reach out any time on Slack if you have questions (or email [email protected]).

It's helpful that you highlighted the spacing style change. This is fine; although ASDK internally does equals-alignment in many places, it's not very appropriate for documentation / areas with only a couple values being set.

@appleguy appleguy merged commit cf58468 into AsyncDisplayKit:master Apr 11, 2017
@sunshinejr sunshinejr deleted the example-swift-containers branch April 11, 2017 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants