Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic plots #160

Merged
merged 8 commits into from
Jun 23, 2021
Merged

Conversation

danjampro
Copy link
Contributor

@danjampro danjampro commented Jun 9, 2021

Add configurable service to make standardised plots on a regular interval.

TODO:

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #160 (ea77d26) into develop (14153f7) will decrease coverage by 4.52%.
The diff coverage is n/a.

❗ Current head ea77d26 differs from pull request most recent head beca0b1. Consider uploading reports for the commit beca0b1 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #160      +/-   ##
===========================================
- Coverage    91.20%   86.68%   -4.53%     
===========================================
  Files           34       35       +1     
  Lines         2332     2426      +94     
===========================================
- Hits          2127     2103      -24     
- Misses         205      323     +118     
Impacted Files Coverage Δ
huntsman-drp/src/huntsman/drp/lsst/utils/calib.py 76.92% <0.00%> (-13.99%) ⬇️
huntsman-drp/src/huntsman/drp/document.py 85.29% <0.00%> (-0.99%) ⬇️
huntsman-drp/src/huntsman/drp/collection.py 91.03% <0.00%> (-0.90%) ⬇️
huntsman-drp/src/huntsman/drp/services/calexp.py 90.16% <0.00%> (-0.75%) ⬇️
huntsman-drp/src/huntsman/drp/lsst/butler.py 92.74% <0.00%> (-0.14%) ⬇️
...tsman-drp/src/huntsman/drp/services/diagnostics.py 0.00% <0.00%> (ø)
huntsman-drp/src/huntsman/drp/lsst/utils/butler.py 97.22% <0.00%> (+1.76%) ⬆️
huntsman-drp/src/huntsman/drp/utils/testing.py 90.62% <0.00%> (+2.22%) ⬆️
huntsman-drp/src/huntsman/drp/services/calib.py 87.69% <0.00%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14153f7...beca0b1. Read the comment docs.

@danjampro danjampro marked this pull request as ready for review June 21, 2021 01:07
@danjampro danjampro added enhancement New feature or request quality control Related to quality control labels Jun 21, 2021
@danjampro danjampro requested a review from fergusL June 21, 2021 01:08
Copy link
Contributor

@fergusL fergusL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danjampro danjampro merged commit c76353c into AstroHuntsman:develop Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quality control Related to quality control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants