Make sure Dynamodb lock context handler doesn't swallow exceptions #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwalton-asana
approved these changes
May 14, 2020
src/dynamodb/lock.py
Outdated
| @@ -7,12 +9,20 @@ | |||
| dynamodb_resource = boto3.resource("dynamodb") | |||
|
|
|||
|
|
|||
| def dynamodb_lock(pull_request_id: str): | |||
| @contextmanager | |||
| def dynamodb_lock(pull_request_id: str, retry_timeout: Optional[timedelta] = None): | |||
There was a problem hiding this comment.
While we're here, could we rename the pull_request_id parameter? In at least one case we pass a commit_id for this.
| from datetime import timedelta | ||
| from python_dynamodb_lock.python_dynamodb_lock import DynamoDBLockError # type: ignore | ||
| from test.impl.mock_dynamodb_test_case import MockDynamoDbTestCase | ||
| from src.dynamodb.lock import dynamodb_lock |
There was a problem hiding this comment.
I'm don't know how much it actually matters, but the pep8 standard for imports is:
Imports should be grouped in the following order:
- Standard library imports.
- Related third party imports.
- Local application/library specific imports.
You should put a blank line between each group of imports.
There was a problem hiding this comment.
I think I'm generally sticking to black for formatting, and since the ordering of these is generally pep8 compatible besides the blank line between, I think it's fine and consistent with the other files in the codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the context handler we were using would swallow any exceptions thrown within its block, which made debugging really hard.
There's a related issue in their repo mohankishore/python_dynamodb_lock#426 but it's easy enough to just create a new contextmanager
Pull Request synchronized with Asana task