Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stupid functions.sqf #612

Merged
merged 46 commits into from
Apr 14, 2020
Merged

Remove stupid functions.sqf #612

merged 46 commits into from
Apr 14, 2020

Conversation

blackfisch
Copy link
Contributor

The title should say everything :)

Changes proposed in this pull request:

  • moved all functions in life_server\functions.sqf to client side -> no broadcasting of common functions

  • reworked the functions to be more simple and follow code guidelines (and not check the same thing three times)

  • I have tested my changes and corrected any errors found

@blackfisch blackfisch mentioned this pull request Feb 15, 2020
Open
@blackfisch blackfisch requested a review from DomT602 March 9, 2020 11:09
DomT602
DomT602 reviewed Mar 10, 2020
View reviewed changes
Copy link
Member

@DomT602 DomT602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just another spyglass case change :)

Altis_Life.Altis/config/Config_SpyGlass.hpp Outdated Show resolved Hide resolved
DomT602
DomT602 reviewed Mar 10, 2020
View reviewed changes
Copy link
Member

@DomT602 DomT602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional thoughts - a lot of the phone one's apply to multiple files

Altis_Life.Altis/core/functions/TON/cell/fn_adminmsg.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/core/functions/TON/cell/fn_textcop.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/core/functions/TON/fn_clientGetKey.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/core/functions/TON/fn_isNumber.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/core/functions/TON/cell/fn_emsrequest.sqf Outdated Show resolved Hide resolved
@blackfisch
Copy link
Contributor Author

@DomT602 tested and working.

@blackfisch
Copy link
Contributor Author

still working, confirmed tested

@blackfisch blackfisch requested review from BoGuu and DomT602 March 19, 2020 12:19
@blackfisch blackfisch requested review from BoGuu and DomT602 March 21, 2020 16:49
DomT602
DomT602 requested changes Mar 25, 2020
View reviewed changes
Copy link
Member

@DomT602 DomT602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of BE Filter changes

Altis_Life.Altis/CfgRemoteExec.hpp Show resolved Hide resolved
Altis_Life.Altis/CfgRemoteExec.hpp Show resolved Hide resolved
@blackfisch
Copy link
Contributor Author

will check the BE Filters later, forgot to add them to the battleye folder

@blackfisch blackfisch requested a review from DomT602 March 26, 2020 10:49
DomT602
DomT602 previously approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@DomT602 DomT602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge once re-tested.

@blackfisch
Copy link
Contributor Author

tested - works like a charm

BoGuu
BoGuu previously approved these changes Apr 13, 2020
View reviewed changes
Altis_Life.Altis/core/gangs/fn_gangKick.sqf Outdated Show resolved Hide resolved
@BoGuu
Copy link
Member

BoGuu commented Apr 13, 2020

Assuming it works as intended

@blackfisch
Copy link
Contributor Author

Assuming it works as intended

worked last time i tested it :)

@DomT602 DomT602 merged commit 9878d5a into AsYetUntitled:master Apr 14, 2020
@blackfisch blackfisch deleted the remove-stupid-functions.sqf branch April 18, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Edward-Bakker Edward-Bakker Edward-Bakker left review comments

@BoGuu BoGuu BoGuu approved these changes

@DomT602 DomT602 DomT602 left review comments

Assignees
No one assigned
Labels
6.0.0 enhancement For pull requests and issues that suggest an improvement to an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blackfisch @BoGuu @Edward-Bakker @DomT602